Add methods needed for overflow panels to NativePanel interface.

chrome/browser/ui/panels/native_panel.h

Index: chrome/browser/ui/panels/native_panel.h
diff --git a/chrome/browser/ui/panels/native_panel.h b/chrome/browser/ui/panels/native_panel.h
index 4d1581d81b2273b86d9e09523001176f5c693616..8a0a26b61db06e80c8c32690a171ea47978c9fb9 100644
--- a/chrome/browser/ui/panels/native_panel.h
+++ b/chrome/browser/ui/panels/native_panel.h
@@ -32,6 +32,11 @@ class NativePanel {
   friend class PanelBrowserTest;
 
  protected:
+  enum PanelIconState {

[jennb, 2011/11/28 19:02:01]

Would it violate coding style to move this enum right before the method that
uses it?

+    SHOW_ICON_IN_DESKTOP_BAR,
+    HIDE_ICON_IN_DESKTOP_BAR
+  };

[prasadt, 2011/11/24 03:37:19]

This doesn't apply to Linux as panels don't have presence in the taskbar. If it
doesn't apply for Mac either (which seems to be the case per dimich's comment),
may be we should just move this into windows implementation of NativePanel.

+
   virtual ~NativePanel() {}
 
   virtual void ShowPanel() = 0;
@@ -70,6 +75,17 @@ class NativePanel {
       const gfx::Size& window_size) const = 0;
 
   virtual int TitleOnlyHeight() const = 0;
+
+  // Returns the size of the iconified panel. This is the size we use to draw
+  // the panel put in the overflow area.
+  virtual gfx::Size GetIconifiedPanelSize() const = 0;

[prasadt, 2011/11/24 03:37:19]

When I see iconfiy, minimizing to task bar is what comes to mind. Would
GetOverflowPanelSize() be a better name?

[jennb, 2011/11/28 19:02:01]

Consider determining the size based on what you need to show. E.g. the favicon
and the title is shown, so compute the size in the OverflowStrip by adding
TitleOnlyHeight with icon size and whatever padding between the two. Then maybe
we don't need a new API method here at all.

[Dmitry Titov, 2011/11/30 23:27:01]

It seems we need this method for the same reason as TitleOnlyHeight(). The
platforms have different padding and borders, and even icon size may not be
constant.

+
+  // Brings the panel to the top of the z-order without activating it. This
+  // will make sure that the panel is not obscured by other top-most windows.
+  virtual void EnsurePanelFullyVisible() = 0;

[Dmitry Titov, 2011/11/24 02:21:48]

BringToTopWithoutActivation?

+
+  // Controls if the panel icon should appear in the taskbar or the dock.

[Dmitry Titov, 2011/11/24 02:21:48]

I wonder how we would implement this... Is it possible to just turn on/off? I am
not sure it is possible on mac... It has to be an actual system window minimized
by OS means or an app... So it probably will never be implemented for Mac...
Don't know about Linux.

Also, how about naming it SetPanelIconInDesktopBarState(PanelIconState state)?

[Dmitry Titov, 2011/11/30 23:27:01]

I have an idea about it - you seem to need this method to do whatever OS-specifc
adjustments needs to be done to the representatino of native panel when it goes
to/from overflow bar. Why not have EnterOverflow/ExitOverflow() and let platform
decide actual semantics of update (Win can update taskbar for example while
others can ignore the thing or change layout of titlebar)

+  virtual void UpdatePanelIconInDesktopBar(PanelIconState state) = 0;

[prasadt, 2011/11/24 03:37:19]

Same comment as for PanelIconState.

Appearance/disappearance of panel icon in the taskbar would be a side effect of
some operation, like tear off or overflow, and can be handled as such in Window
NativePanel implementation.

 };
 
 // A NativePanel utility interface used for accessing elements of the