Add methods needed for overflow panels to NativePanel interface.

chrome/browser/ui/panels/native_panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/panels/panel.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 14 matching lines @@
 // 2. We need some additional methods that BrowserWindow doesn't provide, such
 //    as MinimizePanel() and RestorePanel().
 // Note that even though we don't use BrowserWindow directly, Windows and GTK+
 // still use the BrowserWindow interface as part of their implementation so we
 // use Panel in all the method names to avoid collisions.
 class NativePanel {
   friend class Panel;
   friend class PanelBrowserTest;
 
  protected:
+  enum PanelIconState {

[jennb, 2011/11/28 19:02:01]

Would it violate coding style to move this enum right before the method that
uses it?

+    SHOW_ICON_IN_DESKTOP_BAR,
+    HIDE_ICON_IN_DESKTOP_BAR
+  };

[prasadt, 2011/11/24 03:37:19]

This doesn't apply to Linux as panels don't have presence in the taskbar. If it
doesn't apply for Mac either (which seems to be the case per dimich's comment),
may be we should just move this into windows implementation of NativePanel.

+
   virtual ~NativePanel() {}
 
   virtual void ShowPanel() = 0;
   virtual void ShowPanelInactive() = 0;
   virtual gfx::Rect GetPanelBounds() const = 0;
   virtual void SetPanelBounds(const gfx::Rect& bounds) = 0;
   virtual void ClosePanel() = 0;
   virtual void ActivatePanel() = 0;
   virtual void DeactivatePanel() = 0;
   virtual bool IsPanelActive() const = 0;
@@ skipping 18 matching lines @@
   virtual void DestroyPanelBrowser() = 0;
 
   // Returns the exterior size of the panel window given the client content
   // size and vice versa.
   virtual gfx::Size WindowSizeFromContentSize(
       const gfx::Size& content_size) const = 0;
   virtual gfx::Size ContentSizeFromWindowSize(
       const gfx::Size& window_size) const = 0;
 
   virtual int TitleOnlyHeight() const = 0;
+
+  // Returns the size of the iconified panel. This is the size we use to draw
+  // the panel put in the overflow area.
+  virtual gfx::Size GetIconifiedPanelSize() const = 0;

[prasadt, 2011/11/24 03:37:19]

When I see iconfiy, minimizing to task bar is what comes to mind. Would
GetOverflowPanelSize() be a better name?

[jennb, 2011/11/28 19:02:01]

Consider determining the size based on what you need to show. E.g. the favicon
and the title is shown, so compute the size in the OverflowStrip by adding
TitleOnlyHeight with icon size and whatever padding between the two. Then maybe
we don't need a new API method here at all.

[Dmitry Titov, 2011/11/30 23:27:01]

It seems we need this method for the same reason as TitleOnlyHeight(). The
platforms have different padding and borders, and even icon size may not be
constant.

+
+  // Brings the panel to the top of the z-order without activating it. This
+  // will make sure that the panel is not obscured by other top-most windows.
+  virtual void EnsurePanelFullyVisible() = 0;

[Dmitry Titov, 2011/11/24 02:21:48]

BringToTopWithoutActivation?

+
+  // Controls if the panel icon should appear in the taskbar or the dock.

[Dmitry Titov, 2011/11/24 02:21:48]

I wonder how we would implement this... Is it possible to just turn on/off? I am
not sure it is possible on mac... It has to be an actual system window minimized
by OS means or an app... So it probably will never be implemented for Mac...
Don't know about Linux.

Also, how about naming it SetPanelIconInDesktopBarState(PanelIconState state)?

[Dmitry Titov, 2011/11/30 23:27:01]

I have an idea about it - you seem to need this method to do whatever OS-specifc
adjustments needs to be done to the representatino of native panel when it goes
to/from overflow bar. Why not have EnterOverflow/ExitOverflow() and let platform
decide actual semantics of update (Win can update taskbar for example while
others can ignore the thing or change layout of titlebar)

+  virtual void UpdatePanelIconInDesktopBar(PanelIconState state) = 0;

[prasadt, 2011/11/24 03:37:19]

Same comment as for PanelIconState.

Appearance/disappearance of panel icon in the taskbar would be a side effect of
some operation, like tear off or overflow, and can be handled as such in Window
NativePanel implementation.

 };
 
 // A NativePanel utility interface used for accessing elements of the
 // native panel used only by test automation.
 class NativePanelTesting {
  public:
   static NativePanelTesting* Create(NativePanel* native_panel);
   virtual ~NativePanelTesting() {}
 
   virtual void PressLeftMouseButtonTitlebar(const gfx::Point& point) = 0;
   virtual void ReleaseMouseButtonTitlebar() = 0;
   virtual void DragTitlebar(int delta_x, int delta_y) = 0;
   virtual void CancelDragTitlebar() = 0;
   virtual void FinishDragTitlebar() = 0;
 
   // Verifies, on a deepest possible level, if the Panel is showing the "Draw
   // Attention" effects to the user. May include checking colors etc.
   virtual bool VerifyDrawingAttention() const = 0;
   // Verifies, on a deepest possible level, if the native panel is really
   // active, i.e. the titlebar is painted per its active state.
   virtual bool VerifyActiveState(bool is_active) = 0;
   virtual void WaitForWindowCreationToComplete() const { }
 
   virtual bool IsWindowSizeKnown() const = 0;
   virtual bool IsAnimatingBounds() const = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_