Group forms-related files in webkit/glue in a forms/ subdirectory.

Group forms-related files in webkit/glue in a forms/ subdirectory.

BUG=none
TEST=compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114581

[tony, 2011-11-24 17:10:15]

This seems OK, but we could also move these files to src/webkit/forms and give
it its own gypi file.  In the long term, I think that's the direction we want to
go:
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

[Ilya Sherman, 2011-11-28 09:48:30]

On 2011/11/24 17:10:15, tony wrote:
> This seems OK, but we could also move these files to src/webkit/forms and give
> it its own gypi file.  In the long term, I think that's the direction we want
to
> go:
>
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

I did see that thread, but I do not understand why src/webkit/forms is a more
appropriate location than src/webkit/glue/forms.  [1] suggests that the "glue"
folder is not just a dumping ground, but rather a sort of API translation layer.
 Similarly, Darin's reply in [2] suggests that glue/ provides a set of
serializable types that mirror native WebKit objects.  Is that grouping no
longer relevant, or now implied simply by being one of several subdirectories of
src/webkit?

[1]
http://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
[2]
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

[tony, 2011-11-28 17:43:08]

On 2011/11/28 09:48:30, Ilya Sherman wrote:
> On 2011/11/24 17:10:15, tony wrote:
> > This seems OK, but we could also move these files to src/webkit/forms and
give
> > it its own gypi file.  In the long term, I think that's the direction we
want
> to
> > go:
> >
>
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...
> 
> I did see that thread, but I do not understand why src/webkit/forms is a more
> appropriate location than src/webkit/glue/forms.  [1] suggests that the "glue"
> folder is not just a dumping ground, but rather a sort of API translation
layer.
>  Similarly, Darin's reply in [2] suggests that glue/ provides a set of
> serializable types that mirror native WebKit objects.  Is that grouping no
> longer relevant, or now implied simply by being one of several subdirectories
of
> src/webkit?

The latter.  Most of the directories in src/webkit are 'glue' layers, they're
just organized by feature rather than all being placed in glue.  Specifically,
appcache, blob, fileapi, gpu, media, plugins, and quota are all 'glue' layers,
but also have feature specific implementation files.

[Ilya Sherman, 2011-12-13 07:20:38]

On 2011/11/28 17:43:08, tony wrote:
> On 2011/11/28 09:48:30, Ilya Sherman wrote:
> > On 2011/11/24 17:10:15, tony wrote:
> > > This seems OK, but we could also move these files to src/webkit/forms

Done.

[tony, 2011-12-13 18:05:51]

LGTM, thanks!

[commit-bot: I haz the power, 2011-12-13 19:25:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/8680040/26003

[commit-bot: I haz the power, 2011-12-13 19:29:46]

Presubmit check for 8680040-26003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/tab_contents/test_tab_contents.cc,chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc,chrome/browser/sync/glue/password_change_processor.cc,chrome/browser/sync/glue/password_model_associator.cc,chrome/browser/sync/test/integration/passwords_helper.cc,chrome/browser/sync/test/integration/passwords_helper.h,content/public/common/webkit_param_traits.cc,content/public/renderer/document_state.h,chrome/browser/sync/test/integration/multiple_client_passwords_sync_test.cc,content/browser/tab_contents/tab_contents.cc,chrome/browser/sync/profile_sync_service_password_unittest.cc,content/public/renderer/document_state.cc,chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc,content/public/common/frame_navigate_params.h,content/public/common/webkit_param_traits.h,chrome/browser/sync/test/integration/autofill_helper.cc,chrome/browser/sync/glue/password_model_associator.h,content/browser/renderer_host/test_render_view_host.cc,chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc,content/browser/tab_contents/tab_contents_unittest.cc,content/renderer/render_view_impl.cc

Presubmit checks took 21.0s to calculate.

[Ilya Sherman, 2011-12-13 21:10:11]

+jam, akalin for OWNERS reviews

[akalin, 2011-12-14 00:49:16]

sync LGTM

[Avi (use Gerrit), 2011-12-14 21:14:49]

content LGTM

[commit-bot: I haz the power, 2011-12-14 22:05:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/8680040/28001

[commit-bot: I haz the power, 2011-12-14 23:01:53]

Try job failure for 8680040-28001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-14 23:24:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/8680040/31002

[commit-bot: I haz the power, 2011-12-15 00:06:55]

Try job failure for 8680040-31002 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-15 00:51:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/8680040/37001

[commit-bot: I haz the power, 2011-12-15 02:25:14]

Change committed as 114581