chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc - Issue 8680040: Group forms-related files in webkit/glue in a forms/ subdirectory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

Issue 8680040: Group forms-related files in webkit/glue in a forms/ subdirectory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + another build fix Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/passwords_helper.cc ('k') | chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

diff --git a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

index a8ed771a7b97b583b7fdd2db8549cad4facde884..58f7d6920bfccab55a62689baf2be3e15e9f4f0d 100644

--- a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

+++ b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

@@ -34,7 +34,7 @@ class PasswordsSyncPerfTest : public SyncTest {

private:

// Returns a new unique login.

- webkit_glue::PasswordForm NextLogin();

+ webkit::forms::PasswordForm NextLogin();

// Returns a new unique password value.

std::string NextPassword();

@@ -50,9 +50,9 @@ void PasswordsSyncPerfTest::AddLogins(int profile, int num_logins) {

}

void PasswordsSyncPerfTest::UpdateLogins(int profile) {

- std::vector<webkit_glue::PasswordForm> logins;

+ std::vector<webkit::forms::PasswordForm> logins;

GetLogins(GetPasswordStore(profile), logins);

- for (std::vector<webkit_glue::PasswordForm>::iterator it = logins.begin();

+ for (std::vector<webkit::forms::PasswordForm>::iterator it = logins.begin();

it != logins.end(); ++it) {

(*it).password_value = ASCIIToUTF16(NextPassword());

UpdateLogin(GetPasswordStore(profile), (*it));

@@ -63,7 +63,7 @@ void PasswordsSyncPerfTest::RemoveLogins(int profile) {

passwords_helper::RemoveLogins(GetPasswordStore(profile));

}

-webkit_glue::PasswordForm PasswordsSyncPerfTest::NextLogin() {

+webkit::forms::PasswordForm PasswordsSyncPerfTest::NextLogin() {

return CreateTestPasswordForm(password_number_++);

}