Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: content/public/common/resource_response.h

Issue 8680036: Move ResourceResponse struct into the Content API, since it's used in Chrome. While at it, I also... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/resource_response.h
===================================================================
--- content/public/common/resource_response.h (revision 111374)
+++ content/public/common/resource_response.h (working copy)
@@ -4,18 +4,21 @@
// See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
-#ifndef CONTENT_COMMON_RESOURCE_RESPONSE_H_
-#define CONTENT_COMMON_RESOURCE_RESPONSE_H_
+#ifndef CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
+#define CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
#pragma once
#include <string>
+#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
#include "googleurl/src/gurl.h"
#include "net/url_request/url_request_status.h"
#include "webkit/glue/resource_loader_bridge.h"
+namespace content {
+
// Parameters for a resource response header.
struct ResourceResponseHead : webkit_glue::ResourceResponseInfo {
// The response status.
@@ -33,15 +36,15 @@
// Simple wrapper that refcounts ResourceResponseHead.
struct CONTENT_EXPORT ResourceResponse
- : public base::RefCounted<ResourceResponse> {
- ResourceResponse();
+ : public NON_EXPORTED_BASE(ResourceResponseHead),
+ public base::RefCounted<ResourceResponse> {
- ResourceResponseHead response_head;
-
private:
friend class base::RefCounted<ResourceResponse>;
- ~ResourceResponse();
+ ~ResourceResponse() {}
Dirk Pranke 2011/11/24 00:30:47 I'm still a bit fuzzy on the rules for when we're
jam 2011/11/24 00:42:18 The errors I get when there are template member va
};
-#endif // CONTENT_COMMON_RESOURCE_RESPONSE_H_
+} // namespace content
+
+#endif // CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
« no previous file with comments | « content/public/browser/resource_dispatcher_host_delegate.h ('k') | content/test/render_view_fake_resources_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698