Move ResourceResponse struct into the Content API, since it's used in Chrome. While at it, I also...

content/public/common/resource_response.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
-#ifndef CONTENT_COMMON_RESOURCE_RESPONSE_H_
-#define CONTENT_COMMON_RESOURCE_RESPONSE_H_
+#ifndef CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
+#define CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_
 #pragma once
 
 #include <string>
 
+#include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 #include "googleurl/src/gurl.h"
 #include "net/url_request/url_request_status.h"
 #include "webkit/glue/resource_loader_bridge.h"
 
+namespace content {
+
 // Parameters for a resource response header.
 struct ResourceResponseHead : webkit_glue::ResourceResponseInfo {
   // The response status.
   net::URLRequestStatus status;
 };
 
 // Parameters for a synchronous resource response.
 struct SyncLoadResult : ResourceResponseHead {
   // The final URL after any redirects.
   GURL final_url;
 
   // The response data.
   std::string data;
 };
 
 // Simple wrapper that refcounts ResourceResponseHead.
 struct CONTENT_EXPORT ResourceResponse
-    : public base::RefCounted<ResourceResponse> {
-  ResourceResponse();
-
-  ResourceResponseHead response_head;
+    : public NON_EXPORTED_BASE(ResourceResponseHead),
+      public base::RefCounted<ResourceResponse> {
 
  private:
   friend class base::RefCounted<ResourceResponse>;
 
-  ~ResourceResponse();
+  ~ResourceResponse() {}

[Dirk Pranke, 2011/11/24 00:30:47]

I'm still a bit fuzzy on the rules for when we're allowed to inline constructors
and destructors ... here it looks like you're letting the compiler generate a
public constructor, and you're declaring the destructor private so that it can't
be subclassed, right? Are you sure that both of these should be inlined, since
they contain strings and GURLS?

[jam, 2011/11/24 00:42:18]

The errors I get when there are template member variables etc. I did send this
through the clang bot which didn't complain

 };
 
-#endif  // CONTENT_COMMON_RESOURCE_RESPONSE_H_
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_COMMON_RESOURCE_RESPONSE_H_