Move ResourceResponse struct into the Content API, since it's used in Chrome. While at it, I also...

Move ResourceResponse struct into the Content API, since it's used in Chrome. While at it, I also made the ResourceResponse wrapper just derive from ResourceResponseHead, so that the parameters are accessed directly, instead of having to go through a member variable.

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111471

[Dirk Pranke, 2011-11-24 00:30:47]

lgtm, apart from the one question below (which I don't actually know the right
answer to).

http://codereview.chromium.org/8680036/diff/1/content/public/common/resource_...
File content/public/common/resource_response.h (right):

http://codereview.chromium.org/8680036/diff/1/content/public/common/resource_...
content/public/common/resource_response.h:45: ~ResourceResponse() {}
I'm still a bit fuzzy on the rules for when we're allowed to inline constructors
and destructors ... here it looks like you're letting the compiler generate a
public constructor, and you're declaring the destructor private so that it can't
be subclassed, right? Are you sure that both of these should be inlined, since
they contain strings and GURLS?

[jam, 2011-11-24 00:42:18]

http://codereview.chromium.org/8680036/diff/1/content/public/common/resource_...
File content/public/common/resource_response.h (right):

http://codereview.chromium.org/8680036/diff/1/content/public/common/resource_...
content/public/common/resource_response.h:45: ~ResourceResponse() {}
On 2011/11/24 00:30:47, Dirk Pranke wrote:
> I'm still a bit fuzzy on the rules for when we're allowed to inline
constructors
> and destructors ... here it looks like you're letting the compiler generate a
> public constructor, and you're declaring the destructor private so that it
can't
> be subclassed, right? Are you sure that both of these should be inlined, since
> they contain strings and GURLS?

The errors I get when there are template member variables etc. I did send this
through the clang bot which didn't complain