Remove the static qualifier from functions in header files.

Remove the static qualifier from functions in header files.

This shaves 416+ KB, just under 1% off the size of the debug d8 executable
on Linux (mostly because the CheckHelper functions for assertions were
getting separate copies for each compilation unit).  The difference in
release builds is negligible---a size reduction of 0.1%.

Also, change namespace-level 'static const' variables to remove the static
storage class as it's the default.

R=danno@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=10083

[Kevin Millikin (Chromium), 2011-11-23 16:15:07]

I can't think of a really good reason to put static functions in headers (and I
can think of a bad reason).

[joth, 2011-11-23 16:58:50]

Drive-by on this one file...

http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/8680013/diff/1/src/arm/assembler-arm.h#newcode309
src/arm/assembler-arm.h:309: extern const DwVfpRegister& kDoubleRegZero;
disclaimer: I added the reference to remove ~ 40 static initializers.

I would have thought as it were before, they'd be straight compile time aliases,
but with extern it could need extra relocation records?

Also not quite clear why an extern reference is better? I think this would now
violate (&kDoubleRegZero == &d14) when used in an arbitrary .cc, for what that's
worth.

[Kevin Millikin (Chromium), 2011-11-24 11:47:06]

Redirecting to Erik.

[Erik Corry, 2011-11-29 09:34:55]

LGTM

http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h
File src/conversions-inl.h (right):

http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h#newcod...
src/conversions-inl.h:107: EndMark end,
Indentation.

http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h#newcod...
src/conversions-inl.h:122: inline bool AdvanceToNonspace(UnicodeCache*
unicode_cache,
Indentation

[Kevin Millikin (Chromium), 2011-11-29 10:10:34]

http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h
File src/conversions-inl.h (right):

http://codereview.chromium.org/8680013/diff/4001/src/conversions-inl.h#newcod...
src/conversions-inl.h:107: EndMark end,
On 2011/11/29 09:34:56, Erik Corry wrote:
> Indentation.

Thanks.