Chromium Code Reviews| Index: src/conversions-inl.h |
| diff --git a/src/conversions-inl.h b/src/conversions-inl.h |
| index 8bc11bf83dcb75b9cf2d3d0e23ebe0855049d201..20a5d471ce77aa519f955b69ef303f9604294d74 100644 |
| --- a/src/conversions-inl.h |
| +++ b/src/conversions-inl.h |
| @@ -46,7 +46,7 @@ |
| namespace v8 { |
| namespace internal { |
| -static inline double JunkStringValue() { |
| +inline double JunkStringValue() { |
| return BitCast<double, uint64_t>(kQuietNaNMask); |
| } |
| @@ -54,7 +54,7 @@ static inline double JunkStringValue() { |
| // The fast double-to-unsigned-int conversion routine does not guarantee |
| // rounding towards zero, or any reasonable value if the argument is larger |
| // than what fits in an unsigned 32-bit integer. |
| -static inline unsigned int FastD2UI(double x) { |
| +inline unsigned int FastD2UI(double x) { |
| // There is no unsigned version of lrint, so there is no fast path |
| // in this function as there is in FastD2I. Using lrint doesn't work |
| // for values of 2^31 and above. |
| @@ -80,7 +80,7 @@ static inline unsigned int FastD2UI(double x) { |
| } |
| -static inline double DoubleToInteger(double x) { |
| +inline double DoubleToInteger(double x) { |
| if (isnan(x)) return 0; |
| if (!isfinite(x) || x == 0) return x; |
| return (x >= 0) ? floor(x) : ceil(x); |
| @@ -103,7 +103,7 @@ int32_t DoubleToInt32(double x) { |
| template <class Iterator, class EndMark> |
| -static bool SubStringEquals(Iterator* current, |
| +bool SubStringEquals(Iterator* current, |
| EndMark end, |
|
Erik Corry
2011/11/29 09:34:56
Indentation.
Kevin Millikin (Chromium)
2011/11/29 10:10:34
Thanks.
|
| const char* substring) { |
| ASSERT(**current == *substring); |
| @@ -119,7 +119,7 @@ static bool SubStringEquals(Iterator* current, |
| // Returns true if a nonspace character has been found and false if the |
| // end was been reached before finding a nonspace character. |
| template <class Iterator, class EndMark> |
| -static inline bool AdvanceToNonspace(UnicodeCache* unicode_cache, |
| +inline bool AdvanceToNonspace(UnicodeCache* unicode_cache, |
|
Erik Corry
2011/11/29 09:34:56
Indentation
|
| Iterator* current, |
| EndMark end) { |
| while (*current != end) { |
| @@ -132,11 +132,11 @@ static inline bool AdvanceToNonspace(UnicodeCache* unicode_cache, |
| // Parsing integers with radix 2, 4, 8, 16, 32. Assumes current != end. |
| template <int radix_log_2, class Iterator, class EndMark> |
| -static double InternalStringToIntDouble(UnicodeCache* unicode_cache, |
| - Iterator current, |
| - EndMark end, |
| - bool negative, |
| - bool allow_trailing_junk) { |
| +double InternalStringToIntDouble(UnicodeCache* unicode_cache, |
| + Iterator current, |
| + EndMark end, |
| + bool negative, |
| + bool allow_trailing_junk) { |
| ASSERT(current != end); |
| // Skip leading 0s. |
| @@ -235,10 +235,10 @@ static double InternalStringToIntDouble(UnicodeCache* unicode_cache, |
| template <class Iterator, class EndMark> |
| -static double InternalStringToInt(UnicodeCache* unicode_cache, |
| - Iterator current, |
| - EndMark end, |
| - int radix) { |
| +double InternalStringToInt(UnicodeCache* unicode_cache, |
| + Iterator current, |
| + EndMark end, |
| + int radix) { |
| const bool allow_trailing_junk = true; |
| const double empty_string_val = JunkStringValue(); |
| @@ -430,11 +430,11 @@ static double InternalStringToInt(UnicodeCache* unicode_cache, |
| // 2. *current - gets the current character in the sequence. |
| // 3. ++current (advances the position). |
| template <class Iterator, class EndMark> |
| -static double InternalStringToDouble(UnicodeCache* unicode_cache, |
| - Iterator current, |
| - EndMark end, |
| - int flags, |
| - double empty_string_val) { |
| +double InternalStringToDouble(UnicodeCache* unicode_cache, |
| + Iterator current, |
| + EndMark end, |
| + int flags, |
| + double empty_string_val) { |
| // To make sure that iterator dereferencing is valid the following |
| // convention is used: |
| // 1. Each '++current' statement is followed by check for equality to 'end'. |