Issue 8678010: Add ui/views/* to the views WATCHLIST.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8678010: Add ui/views/* to the views WATCHLIST. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years ago

Reviewers:
sky, Nirnimesh

CC:
chromium-reviews, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ui/views/* to the views WATCHLIST. TEST=python ~/depot_tools/watchlists.py ui/views/ R=sky@chromium.org,nirnimesh@chromium.org TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111552

Patch Set 2 : nirnimesh review #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	WATCHLISTS	View	1	1 chunk	+5 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/8678010/diff/1/WATCHLISTS File WATCHLISTS (right): http://codereview.chromium.org/8678010/diff/1/WATCHLISTS#newcode28 WATCHLISTS:28: 'filepath': '^views/.*'\ These are wrong. There needs to be ...

9 years, 1 month ago (2011-11-23 22:13:57 UTC) #2

tfarina

9 years, 1 month ago (2011-11-23 22:30:15 UTC) #3

sky

9 years ago (2011-11-28 15:48:25 UTC) #5

http://codereview.chromium.org/8678010/diff/4001/WATCHLISTS
File WATCHLISTS (right):

http://codereview.chromium.org/8678010/diff/4001/WATCHLISTS#newcode29
WATCHLISTS:29: '^ui/views/.*',
Why bother wrapping this? Also, aren't you moving everything to ui/views so that
the views/ paths can be removed?

Expand Messages | Collapse Messages

Issue 8678010: Add ui/views/* to the views WATCHLIST. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nirnimesh review #

Messages