Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Side by Side Diff: WATCHLISTS

Issue 8678010: Add ui/views/* to the views WATCHLIST. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nirnimesh review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Watchlist Rules 5 # Watchlist Rules
6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists 6 # Refer: http://dev.chromium.org/developers/contributing-code/watchlists
7 7
8 8
9 { 9 {
10 'WATCHLIST_DEFINITIONS': { 10 'WATCHLIST_DEFINITIONS': {
11 'this_file': { 11 'this_file': {
12 'filepath': '^WATCHLISTS$', 12 'filepath': '^WATCHLISTS$',
13 }, 13 },
14 'valgrind': { 14 'valgrind': {
15 'filepath': 'valgrind', 15 'filepath': 'valgrind',
16 }, 16 },
17 'mac': { 17 'mac': {
18 'filepath': 'cocoa|\.mm$|(_mac|_posix)\.(cc|h)$', 18 'filepath': 'cocoa|\.mm$|(_mac|_posix)\.(cc|h)$',
19 }, 19 },
20 'base': { 20 'base': {
21 'filepath': '^base/.*', 21 'filepath': '^base/.*',
22 }, 22 },
23 'extension': { 23 'extension': {
24 'filepath': 'extension', 24 'filepath': 'extension',
25 }, 25 },
26 'views': { 26 'views': {
27 # Applies to all files and subdirs within this directory. 27 # Applies to all files and subdirs within this directory.
28 'filepath': '^views/.*', 28 'filepath': '^views/.*|'\
29 '^ui/views/.*',
sky 2011/11/28 15:48:25 Why bother wrapping this? Also, aren't you moving
29 }, 30 },
30 'aura': { 31 'aura': {
31 'filepath': 'ui/aura/.*'\ 32 'filepath': 'ui/aura/.*|'\
32 'ui/aura_shell/.*', 33 'ui/aura_shell/.*',
33 }, 34 },
34 'views_core': { 35 'views_core': {
35 'filepath': 'views/view.h'\ 36 'filepath': 'views/view.h|'\
36 'views/view.cc'\ 37 'views/view.cc|'\
37 'views/widget/.*', 38 'views/widget/.*',
38 }, 39 },
39 'browser': { 40 'browser': {
40 'filepath': 'chrome/browser/.*', 41 'filepath': 'chrome/browser/.*',
41 }, 42 },
42 'browser_main': { 43 'browser_main': {
43 'filepath': 'chrome/browser/browser_main.cc', 44 'filepath': 'chrome/browser/browser_main.cc',
44 }, 45 },
45 'browser_resources': { 46 'browser_resources': {
46 'filepath': 'chrome/browser/resources/.*', 47 'filepath': 'chrome/browser/resources/.*',
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 'browser_compositor': ['backer@chromium.org', 'vollick@chromium.org', 417 'browser_compositor': ['backer@chromium.org', 'vollick@chromium.org',
417 'piman+watch@chromium.org'], 418 'piman+watch@chromium.org'],
418 'textinput': ['penghuang+watch@chromium.org', 419 'textinput': ['penghuang+watch@chromium.org',
419 'suzhe@chromium.org', 420 'suzhe@chromium.org',
420 'yusukes+watch@chromium.org'], 421 'yusukes+watch@chromium.org'],
421 'omnibox': ['suzhe@chromium.org'], 422 'omnibox': ['suzhe@chromium.org'],
422 'message_loop': ['sadrul@chromium.org'], 423 'message_loop': ['sadrul@chromium.org'],
423 'clipboard': ['dcheng@chromium.org'], 424 'clipboard': ['dcheng@chromium.org'],
424 }, 425 },
425 } 426 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698