Use new os_posix define in ffmpeg.gyp

Use os_posix in gyp file, this patch has been tested on FreeBSD, Solaris, and NetBSD.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111804

[ruben, 2011-11-23 01:02:12]

Please review this small patch.

[scherkus (not reviewing), 2011-11-23 01:22:53]

few nits

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp
File ffmpeg.gyp (right):

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp#newcode27
ffmpeg.gyp:27: ['os_posix != 1 or OS == "mac" or OS == "openbsd"', {
nit: no spaces around operators (!=, ==, etc..)

[ruben, 2011-11-23 01:36:14]

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp
File ffmpeg.gyp (right):

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp#newcode27
ffmpeg.gyp:27: ['os_posix != 1 or OS == "mac" or OS == "openbsd"', {
On 2011/11/23 01:22:54, scherkus wrote:
> nit: no spaces around operators (!=, ==, etc..)
I was told otherwise by estade here:

http://codereview.chromium.org/7011032/#msg5

Both idioms are currently used, with your idiom used more often.  I honestly
don't care about the spacing, just following what I was told.

[scherkus (not reviewing), 2011-11-23 01:46:25]

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp
File ffmpeg.gyp (right):

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp#newcode27
ffmpeg.gyp:27: ['os_posix != 1 or OS == "mac" or OS == "openbsd"', {
On 2011/11/23 01:36:15, ruben wrote:
> On 2011/11/23 01:22:54, scherkus wrote:
> > nit: no spaces around operators (!=, ==, etc..)
> I was told otherwise by estade here:
> 
> http://codereview.chromium.org/7011032/#msg5
> 
> Both idioms are currently used, with your idiom used more often.  I honestly
> don't care about the spacing, just following what I was told.

estade@ made a comment about consistency, which would apply here but in reverse
:)

currently the rest of this file has no spaces -- you would be introducing a
mixture which would forever cause confusion among future developers

sorry to nit about this stuff  :\

[ruben, 2011-11-23 02:17:14]

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp
File ffmpeg.gyp (right):

http://codereview.chromium.org/8673004/diff/3/ffmpeg.gyp#newcode27
ffmpeg.gyp:27: ['os_posix != 1 or OS == "mac" or OS == "openbsd"', {
On 2011/11/23 01:46:25, scherkus wrote:
> estade@ made a comment about consistency, which would apply here but in
reverse
> :)
If you follow that thread a couple comments down, he said Chromium should be
using the python style guidelines and asked that I use spaces for new patches. 
Chromium is already inconsistent on this spacing issue, nothing short of a
automated spacing commit will change that.
 
> sorry to nit about this stuff  :\
No problem, I just want to be consistent also.  All my patches after estade
asked were committed with spaces.  If you still don't want spaces in this one,
let me know and I'll take them out.

[scherkus (not reviewing), 2011-11-23 02:45:10]

ah didn't really the entire thread

LGTM then

[ruben, 2011-11-28 22:54:33]

On 2011/11/23 02:45:10, scherkus wrote:
> ah didn't really the entire thread
> 
> LGTM then
I tried flipping the commit bit here on rietveld last week but nothing appears
to have happened.  I'm guessing I don't have commit privileges, perhaps you need
to apply manually?

[scherkus (not reviewing), 2011-11-28 23:09:04]

Ah right it's because it's outside of src/ directory.

Committed as r111804

I'll update src/DEPS to pull this in soon