Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: vm/dart_api_impl.cc

Issue 8673002: - Refactor the isolate callback mechanism to also include creation of the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/dart_api_impl.cc
===================================================================
--- vm/dart_api_impl.cc (revision 1771)
+++ vm/dart_api_impl.cc (working copy)
@@ -465,7 +465,7 @@
// TODO(iposva): This is a placeholder for the eventual external Dart API.
DART_EXPORT bool Dart_Initialize(int argc,
const char** argv,
- Dart_IsolateInitCallback callback) {
+ Dart_IsolateCreateAndInitCallback callback) {
return Dart::InitOnce(argc, argv, callback);
}
@@ -481,15 +481,14 @@
// --- Isolates ---
-DART_EXPORT Dart_Isolate Dart_CreateIsolate(const Dart_Snapshot* snapshot,
- void* data) {
+DART_EXPORT Dart_Isolate Dart_CreateIsolate(const Dart_Snapshot* snapshot) {
Isolate* isolate = Dart::CreateIsolate();
ASSERT(isolate != NULL);
LongJump* base = isolate->long_jump_base();
LongJump jump;
isolate->set_long_jump_base(&jump);
if (setjmp(*jump.Set()) == 0) {
- Dart::InitializeIsolate(snapshot, data);
+ Dart::InitializeIsolate(snapshot);
START_TIMER(time_total_runtime);
isolate->set_long_jump_base(base);
return reinterpret_cast<Dart_Isolate>(isolate);

Powered by Google App Engine
This is Rietveld 408576698