Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: vm/dart_api_impl_test.cc

Issue 8673002: - Refactor the isolate callback mechanism to also include creation of the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/dart.h ('K') | « vm/dart_api_impl.cc ('k') | vm/isolate.h » ('j') | vm/isolate_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_api_impl_test.cc
===================================================================
--- vm/dart_api_impl_test.cc (revision 1771)
+++ vm/dart_api_impl_test.cc (working copy)
@@ -24,7 +24,7 @@
" }\n"
"}\n";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
@@ -68,7 +68,7 @@
UNIT_TEST_CASE(Dart_Error) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle error = Dart_Error("An %s", "error");
@@ -81,7 +81,7 @@
UNIT_TEST_CASE(Null) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
Dart_Handle null = Dart_Null();
@@ -98,7 +98,7 @@
UNIT_TEST_CASE(IsSame) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
bool same = false;
@@ -141,7 +141,7 @@
#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
UNIT_TEST_CASE(ObjectEquals) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
bool equal = false;
@@ -168,7 +168,7 @@
#endif
UNIT_TEST_CASE(BooleanValues) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
Dart_Handle str = Dart_NewString("test");
@@ -198,7 +198,7 @@
UNIT_TEST_CASE(BooleanConstants) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
Dart_Handle true_handle = Dart_True();
@@ -224,7 +224,7 @@
UNIT_TEST_CASE(DoubleValues) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
const double kDoubleVal1 = 201.29;
@@ -259,7 +259,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -312,7 +312,7 @@
UNIT_TEST_CASE(IntegerValues) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
const int64_t kIntegerVal1 = 100;
@@ -358,7 +358,7 @@
UNIT_TEST_CASE(ArrayValues) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
const int kArrayLength = 10;
@@ -400,7 +400,7 @@
UNIT_TEST_CASE(IsString) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
@@ -469,7 +469,7 @@
"}";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -586,7 +586,7 @@
// Unit test for entering a scope, creating a local handle and exiting
// the scope.
UNIT_TEST_CASE(EnterExitScope) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
ApiState* state = isolate->api_state();
@@ -612,7 +612,7 @@
UNIT_TEST_CASE(PersistentHandles) {
const char* kTestString1 = "Test String1";
const char* kTestString2 = "Test String2";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
ApiState* state = isolate->api_state();
@@ -678,7 +678,7 @@
// Test that we are able to create a persistent handle from a
// persistent handle.
UNIT_TEST_CASE(NewPersistentHandle_FromPersistentHandle) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
@@ -708,7 +708,7 @@
// Ensure that the local handles get all cleaned out when exiting the
// scope.
UNIT_TEST_CASE(LocalHandles) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
ApiState* state = isolate->api_state();
@@ -775,7 +775,7 @@
// zone for the scope. Ensure that the memory is freed when the scope
// exits.
UNIT_TEST_CASE(LocalZoneMemory) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
ApiState* state = isolate->api_state();
@@ -821,14 +821,14 @@
UNIT_TEST_CASE(Isolates) {
// This test currently assumes that the Dart_Isolate type is an opaque
// representation of Isolate*.
- Dart_Isolate iso_1 = Dart_CreateIsolate(NULL, NULL);
+ Dart_Isolate iso_1 = Dart_CreateIsolate(NULL);
EXPECT_EQ(iso_1, Isolate::Current());
Dart_Isolate isolate = Dart_CurrentIsolate();
EXPECT_EQ(iso_1, isolate);
Dart_ExitIsolate();
EXPECT(NULL == Isolate::Current());
EXPECT(NULL == Dart_CurrentIsolate());
- Dart_Isolate iso_2 = Dart_CreateIsolate(NULL, NULL);
+ Dart_Isolate iso_2 = Dart_CreateIsolate(NULL);
EXPECT_EQ(iso_2, Isolate::Current());
Dart_ExitIsolate();
EXPECT(NULL == Isolate::Current());
@@ -857,7 +857,7 @@
UNIT_TEST_CASE(SetMessageCallbacks) {
- Dart_Isolate dart_isolate = Dart_CreateIsolate(NULL, NULL);
+ Dart_Isolate dart_isolate = Dart_CreateIsolate(NULL);
Dart_SetMessageCallbacks(&MyPostMessageCallback, &MyClosePortCallback);
Isolate* isolate = reinterpret_cast<Isolate*>(dart_isolate);
EXPECT_EQ(&MyPostMessageCallback, isolate->post_message_callback());
@@ -885,7 +885,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -972,7 +972,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1070,7 +1070,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
const int kNumNativeFields = 4;
@@ -1131,7 +1131,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1173,7 +1173,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
const int kNumNativeFields = 2;
@@ -1227,7 +1227,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1341,7 +1341,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
const int kNumNativeFields = 4;
@@ -1391,7 +1391,7 @@
" return obj;\n"
" }\n"
"}\n";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1436,7 +1436,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
DARTSCOPE(Isolate::Current());
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1514,7 +1514,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1569,7 +1569,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1622,7 +1622,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
DARTSCOPE(Isolate::Current());
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1691,7 +1691,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
DARTSCOPE(Isolate::Current());
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1781,7 +1781,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Isolate* isolate = Isolate::Current();
EXPECT(isolate != NULL);
ApiState* state = isolate->api_state();
@@ -1849,7 +1849,7 @@
" }"
"}";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope();
Dart_Handle lib = TestCase::LoadTestScript(
@@ -1880,7 +1880,7 @@
"class DoesExist {"
"}";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
@@ -1912,7 +1912,7 @@
"}\n";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -1984,7 +1984,7 @@
UNIT_TEST_CASE(NullReceiver) {
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope(); // Enter a Dart API scope for the unit test.
{
DARTSCOPE(Isolate::Current());
@@ -2030,7 +2030,7 @@
" return 12345;"
"}";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle url = Dart_NewString(TestCase::url());
@@ -2098,7 +2098,7 @@
const char* kScriptChars =
")";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle url = Dart_NewString(TestCase::url());
@@ -2120,7 +2120,7 @@
"#library('library1.dart');"
"#import('library2.dart');";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
// Create a test library and Load up a test script in it.
@@ -2167,7 +2167,7 @@
const char* kLibrary1Chars =
"#library('library1_name');";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle url = Dart_NewString("library1_url");
@@ -2209,7 +2209,7 @@
const char* kLibrary2Chars =
"#library('library2_name');";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle error = Dart_Error("incoming error");
@@ -2270,7 +2270,7 @@
const char* kLibrary1Chars =
"#library('library1_name');";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle error = Dart_Error("incoming error");
@@ -2330,7 +2330,7 @@
"#library('library1_name');"
")";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle url = Dart_NewString("library1_url");
@@ -2352,7 +2352,7 @@
const char* kBadSourceChars =
")";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle error = Dart_Error("incoming error");
@@ -2472,7 +2472,7 @@
" static baz() native \"SomeNativeFunction3\";"
"}";
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
Dart_EnterScope();
Dart_Handle error = Dart_Error("incoming error");
@@ -2577,7 +2577,7 @@
"var foo;";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -2625,7 +2625,7 @@
"var foo;";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -2669,7 +2669,7 @@
"var foo;";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -2735,7 +2735,7 @@
"var fooC;";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
@@ -2798,7 +2798,7 @@
"}";
Dart_Handle result;
- Dart_CreateIsolate(NULL, NULL);
+ Dart_CreateIsolate(NULL);
{
Dart_EnterScope(); // Start a Dart API scope for invoking API functions.
« vm/dart.h ('K') | « vm/dart_api_impl.cc ('k') | vm/isolate.h » ('j') | vm/isolate_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698