Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 8672011: Add more Unix platforms to Skia (Closed)

Created:
9 years, 1 month ago by ruben
Modified:
9 years ago
Reviewers:
reed1
Base URL:
http://git.chromium.org/external/skia/include.git@master
Visibility:
Public.

Description

Add more Unix platforms on which Skia for Chromium has been built, this patch was tested on FreeBSD, Solaris, NetBSD, and DragonFly BSD. Committed: http://code.google.com/p/skia/source/detail?r=2764 Committed: http://code.google.com/p/skia/source/detail?r=2775

Patch Set 1 #

Patch Set 2 : fix openbsd typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M core/SkPreConfig.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ruben
Please review.
9 years, 1 month ago (2011-11-23 04:44:09 UTC) #1
reed1
better to submit the diff based on your skia/trunk, not skia/trunk/include
9 years ago (2011-11-30 15:21:40 UTC) #2
reed1
testing the patch now...
9 years ago (2011-11-30 15:21:57 UTC) #3
ruben
On 2011/11/30 15:21:40, reed1 wrote: > better to submit the diff based on your skia/trunk, ...
9 years ago (2011-11-30 20:02:19 UTC) #4
ruben
Just noticed that my first patch pulled in your OpenBSD typo, fixed.
9 years ago (2011-11-30 20:27:52 UTC) #5
reed1
committed in skia rev. 2775 Skia patches should be submitted to codereview.appspot.com, e.g. http://codereview.appspot.com/5302043/ Skia ...
9 years ago (2011-11-30 20:46:32 UTC) #6
Robert Nagy
On 2011/11/30 20:46:32, reed1 wrote: > committed in skia rev. 2775 > > Skia patches ...
9 years ago (2011-12-02 15:57:26 UTC) #7
Robert Nagy
9 years ago (2011-12-02 16:00:33 UTC) #8
On 2011/11/30 20:46:32, reed1 wrote:
> committed in skia rev. 2775
> 
> Skia patches should be submitted to http://codereview.appspot.com, e.g.
> 
> http://codereview.appspot.com/5302043/
> 
> Skia is used in chrome, but chrome just pulls in a r/o copy of some of the
> files.

Oh i guess i just have to do a DEPS change for skia @ 2775. Sorry for the noise.

Powered by Google App Engine
This is Rietveld 408576698