Issue 8672001: Revert 111252 - Switch MHTMLGenerationManager to use a Callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8672001: Revert 111252 - Switch MHTMLGenerationManager to use a Callback. (Closed)

Created:
9 years, 1 month ago by Jay Civelli

Modified:
9 years, 1 month ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Erik does not do reviews, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 111252 - Switch MHTMLGenerationManager to use a Callback. MHTMLGenerationManager now uses a callback instead of a notification. BUG=None TEST=MHTML generation (via extension API should still work). Review URL: http://codereview.chromium.org/8566016 TBR=jcivelli@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111256

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -52 lines)			Patch
M	chrome/browser/extensions/extension_save_page_api.h	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_save_page_api.cc	View	2 chunks	+29 lines, -11 lines	0 comments	Download
M	content/browser/download/mhtml_generation_browsertest.cc	View	4 chunks	+11 lines, -22 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.h	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.cc	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages