Switch MHTMLGenerationManager to use a Callback.

Switch MHTMLGenerationManager to use a Callback.

MHTMLGenerationManager now uses a callback instead of a notification.

BUG=None
TEST=MHTML generation (via extension API should still work).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111252

[Jay Civelli, 2011-11-22 22:16:14]

Mihai,
Could you look at the extension part?

Asanka,
Could you look at the download part?

John,
Could you look at the content/public/browser/notification_types.h part?

[jam, 2011-11-22 23:06:00]

lgtm (yay for removing notifications)

http://codereview.chromium.org/8566016/diff/7001/content/browser/download/mht...
File content/browser/download/mhtml_generation_manager.h (right):

http://codereview.chromium.org/8566016/diff/7001/content/browser/download/mht...
content/browser/download/mhtml_generation_manager.h:27: typedef
base::Callback<void(const FilePath& /* path to the MHTML file */,
nit: can you make these two parameters line up?

[asanka, 2011-11-22 23:19:16]

LGTM

[Jay Civelli, 2011-11-22 23:28:09]

Antony,
Can you look at the extension part?

Thanks.

[asargent_no_longer_on_chrome, 2011-11-22 23:31:26]

LGTM - nice cleanup