Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3055)

Unified Diff: chrome/browser/extensions/settings/settings_backend.h

Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_backend.h
diff --git a/chrome/browser/extensions/settings/settings_backend.h b/chrome/browser/extensions/settings/settings_backend.h
index c9365d8bf65ecea0f043fe984836db638f5307ed..ab368941842619f311dbb97d6ac363f35cbc1d71 100644
--- a/chrome/browser/extensions/settings/settings_backend.h
+++ b/chrome/browser/extensions/settings/settings_backend.h
@@ -28,9 +28,8 @@ class SettingsBackend : public SyncableService {
// |base_path| is the base of the extension settings directory, so the
// databases will be at base_path/extension_id.
// |observers| is the list of observers to settings changes.
- explicit SettingsBackend(
- // Ownership NOT taken.
- SettingsStorageFactory* storage_factory,
+ SettingsBackend(
+ const scoped_refptr<SettingsStorageFactory>& storage_factory,
const FilePath& base_path,
const scoped_refptr<SettingsObserverList>& observers);
@@ -70,8 +69,8 @@ class SettingsBackend : public SyncableService {
// Disable the syncing of the storage area for |extension_id|.
void DisableSyncForExtension(const std::string& extension_id) const;
- // The Factory to use for creating leveldb storage areas. Not owned.
- SettingsStorageFactory* const storage_factory_;
+ // The Factory to use for creating leveldb storage areas.
+ const scoped_refptr<SettingsStorageFactory> storage_factory_;
// The base file path to create any leveldb databases at.
const FilePath base_path_;

Powered by Google App Engine
This is Rietveld 408576698