chrome/browser/extensions/settings/settings_backend.cc - Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_backend.cc

Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/settings/settings_backend.h ('k') | chrome/browser/extensions/settings/settings_frontend.h » ('j') | chrome/browser/extensions/settings/settings_frontend.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings/settings_backend.cc

diff --git a/chrome/browser/extensions/settings/settings_backend.cc b/chrome/browser/extensions/settings/settings_backend.cc

index 2a6fee5f2e7c91532d65d37c5eef0a0ccbd80811..e6fda7de656d0a4a6bc928f10f8a9923bca6fa41 100644

--- a/chrome/browser/extensions/settings/settings_backend.cc

+++ b/chrome/browser/extensions/settings/settings_backend.cc

@@ -39,7 +39,7 @@ const size_t kMaxSettingKeys = 512;

} // namespace

SettingsBackend::SettingsBackend(

- SettingsStorageFactory* storage_factory,

+ const scoped_refptr<SettingsStorageFactory>& storage_factory,

const FilePath& base_path,

const scoped_refptr<SettingsObserverList>& observers)

: storage_factory_(storage_factory),

@@ -61,8 +61,7 @@ SettingsStorage* SettingsBackend::GetStorage(

return GetOrCreateStorageWithSyncData(extension_id, empty);

}

-SyncableSettingsStorage*

-SettingsBackend::GetOrCreateStorageWithSyncData(

+SyncableSettingsStorage* SettingsBackend::GetOrCreateStorageWithSyncData(

const std::string& extension_id, const DictionaryValue& sync_data) const {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));