Issue 8670011: Hide the max queue time / max runtime columns in about:profiler when showing the difference betwe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8670011: Hide the max queue time / max runtime columns in about:profiler when showing the difference betwe... (Closed)

Created:
9 years, 1 month ago by eroman

Modified:
9 years, 1 month ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Hide the max queue time / max runtime columns in about:profiler when showing the difference between two snapshots. The reason to hide it is because we don't currently display the correct values. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111289

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/resources/profiler.js	View		2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

At first, I thought you were changin' the checkboxes... but I see you're just ignoring ...

9 years, 1 month ago (2011-11-23 02:01:52 UTC) #2

eroman

9 years, 1 month ago (2011-11-23 02:04:50 UTC) #3

Yeah exactly.

This is just a quick hack to avoid people getting confused by the max
values before they are fixed.

On Tue, Nov 22, 2011 at 6:01 PM, <jar@chromium.org> wrote:

> At first, I thought you were changin' the checkboxes... but I see you're
> just
> ignoring them when in this mode... which ...
>
> LGTM ;-).
>
> Thanks!
>
>
http://codereview.chromium.**org/8670011/<http://codereview.chromium.org/8670...
>

Expand Messages | Collapse Messages