Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: chrome/browser/resources/profiler.js

Issue 8670011: Hide the max queue time / max runtime columns in about:profiler when showing the difference betwe... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/profiler.js
===================================================================
--- chrome/browser/resources/profiler.js (revision 111280)
+++ chrome/browser/resources/profiler.js (working copy)
@@ -1416,6 +1416,7 @@
getVisibleColumnKeys_: function() {
// Figure out what columns to include, based on the selected checkboxes.
var columns = this.getSelectionColumns_();
+ columns = columns.slice(0);
// Eliminate columns which we are merging on.
deleteValuesFromArray(columns, this.getMergeColumns_());
@@ -1431,10 +1432,14 @@
for (var i = 0; i < randomGroupKey.length; ++i)
keysToExclude.push(randomGroupKey[i].key);
- columns = columns.slice(0);
deleteValuesFromArray(columns, keysToExclude);
}
+ // If we are currently showing a "diff", hide the max columns, since we
+ // are not populating it correctly. See the TODO at the top of this file.
+ if (this.getSelectedSnapshotIndexes_().length > 1)
+ deleteValuesFromArray(columns, [KEY_MAX_RUN_TIME, KEY_MAX_QUEUE_TIME]);
+
return columns;
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698