Issue 8670: Switch to using the message loop rather than gtk_main().

Issue 8670: Switch to using the message loop rather than gtk_main(). (Closed)

Created:
12 years, 1 month ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Switch to using the message loop rather than gtk_main(). Include more code from the main test_shell.cc into the GTK version. Wherever possible the code has been copied and pasted in directly to make the future merge easy.

Patch Set 1 #

Patch Set 2 : Sync with master #

Patch Set 3 : Addressing comments #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+916 lines, -9 lines)			Patch
M	base/logging.h	View	2	2 chunks	+10 lines, -2 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View	2	5 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/gtk/test_shell.cc	View	1	2 chunks	+106 lines, -3 lines	0 comments	Download
A	webkit/tools/test_shell/gtk/test_webview_delegate.cc	View		1 chunk	+780 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/gtk/webwidget_host.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main_gtk.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Rubber stamp on the big files. http://codereview.chromium.org/8670/diff/8/9 File base/logging.h (right): http://codereview.chromium.org/8670/diff/8/9#newcode516 Line 516: #if defined(OS_LINUX) ...

12 years, 1 month ago (2008-10-29 23:28:25 UTC) #2

agl

http://codereview.chromium.org/8670/diff/8/9 File base/logging.h (right): http://codereview.chromium.org/8670/diff/8/9#newcode516 Line 516: #if defined(OS_LINUX) On 2008/10/29 23:28:25, Evan Martin wrote: ...

12 years, 1 month ago (2008-10-29 23:39:22 UTC) #3

tony

12 years, 1 month ago (2008-10-29 23:50:08 UTC) #4

LGTM2.  There's some merging work ahead of us.

On 2008/10/29 23:39:22, agl wrote:
> http://codereview.chromium.org/8670/diff/8/9
> File base/logging.h (right):
> 
> http://codereview.chromium.org/8670/diff/8/9#newcode516
> Line 516: #if defined(OS_LINUX)
> On 2008/10/29 23:28:25, Evan Martin wrote:
> > Should this instead check the compiler?  See base/compiler_specific or some
> > such.
> 
> Switched to COMPILER_GCC
> 
> http://codereview.chromium.org/8670/diff/8/10
> File webkit/glue/webkit_glue.cc (right):
> 
> http://codereview.chromium.org/8670/diff/8/10#newcode413
> Line 413: "Mozilla/5.0 (X11; U; Linux; en-US) Chrome/0.0");
> On 2008/10/29 23:28:25, Evan Martin wrote:
> > We should just copy the full Windows Chrome UA for now.  (Maybe with Win ->
> > Linux.)  We tried a UA string like this and found too many sites broke.
> 
> Switched to the plain Windows user agent string. (With s/Windows/Linux).

Expand Messages | Collapse Messages