Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: webkit/tools/test_shell/test_shell_main_gtk.cc

Issue 8670: Switch to using the message loop rather than gtk_main(). (Closed)
Patch Set: Addressing comments Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/gtk/webwidget_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_main_gtk.cc
diff --git a/webkit/tools/test_shell/test_shell_main_gtk.cc b/webkit/tools/test_shell/test_shell_main_gtk.cc
index afee3e4f8085341649a49820ccff8ef0b67e7adf..48cf47af173c2614ab260df6021683910eae42ae 100644
--- a/webkit/tools/test_shell/test_shell_main_gtk.cc
+++ b/webkit/tools/test_shell/test_shell_main_gtk.cc
@@ -10,6 +10,7 @@
#include "base/icu_util.h"
#include "base/path_service.h"
#include "base/string_util.h"
+#include "base/message_loop.h"
#include "webkit/tools/test_shell/test_shell.h"
#include "webkit/tools/test_shell/test_shell_switches.h"
@@ -53,13 +54,14 @@ int main(int argc, char* argv[]) {
uri = *iter;
}
+ MessageLoopForUI main_message_loop;
+
TestShell* shell;
if (TestShell::CreateNewWindow(uri, &shell)) {
// TODO(port): the rest of this. :)
}
- // TODO(port): use MessageLoop instead.
- gtk_main();
+ main_message_loop.Run();
return 0;
}
« no previous file with comments | « webkit/tools/test_shell/gtk/webwidget_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698