Add arm/tegra2 CQ builders and major cleanup of dead code in chromeos_factory.

Add arm/tegra2 CQ builders and major cleanup of dead code in chromeos_factory.

Simple change to add CQ builders requires a new triggerable.  As I was doing this
I realized this would require a master restart and looked at how much dead code we
had in chromeos_factory.  Since it looks like I understand the legacy reasons for most
of this I have decided to clean up.

THIS CHANGE REQUIRES A MASTER RESTART FOR CBUILDBOT_FACTORIES.

BUG=None
TEST=Running


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111671

[sosa, 2011-11-23 01:03:36]

So far tested with:

commit-queue and chrome pfq's locally.

PTAL, this should move us to a much nicer place.  chromeos_factory was a mess.

[scottz, 2011-11-23 01:50:08]

Nice clean up! 

LGTM with just a few style nits. 

On 2011/11/23 01:03:36, sosa wrote:
> So far tested with:
> 
> commit-queue and chrome pfq's locally.
> 
> PTAL, this should move us to a much nicer place.  chromeos_factory was a mess.

[scottz, 2011-11-23 01:50:16]

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
File scripts/master/factory/chromeos_factory.py (right):

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
scripts/master/factory/chromeos_factory.py:43: def __init__(self,
Nit: generally you either put as many arguments are possible on each line or you
have one by one. here you have a mix. Pick one please.

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
scripts/master/factory/chromeos_factory.py:140:
shell.WithProperties("--buildnumber=%(buildnumber)s"),
Nit: Pick either ' or "

[Peter Mayo, 2011-11-23 14:28:10]

LGTM

Thanks - it's good to see unused history move aside.

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
File scripts/master/factory/chromeos_factory.py (right):

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
scripts/master/factory/chromeos_factory.py:44: buildroot='/b/cbuild', params='',
timeout=9000,
suggest: params='' is a default that doesn't work - we generate a cbuildbot
command that will just fail.  Given that you're juggling all of the parameters
here, could you change the order and make it mandatory?

http://codereview.chromium.org/8669004/diff/1/scripts/master/factory/chromeos...
scripts/master/factory/chromeos_factory.py:106:
command=WithProperties(clear_and_clone_cmd),
suggest: move the WithProperties to where the property is used. (line 95 in this
case) to be the same as add_cbuildbot_step and to be more easily verified
visually.

[sosa, 2011-11-28 03:47:55]

Fixed all nits except the WithProperties as that requires much rework of that
method (is a string that is just appeneded rather than an array and what comes
out of WithProperties is not a simple string)

[commit-bot: I haz the power, 2011-11-28 03:48:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sosa@chromium.org/8669004/4001

[commit-bot: I haz the power, 2011-11-28 03:49:51]

Presubmit check for 8669004-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  build/scripts/master/factory/chromeos_factory.py, line 44, 85 chars

** Presubmit ERRORS **
test/masters_test.py failed!
Command test/masters_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/build
1 masters failed:
master.tryserver.chromium
29 masters succeeded, 1 failed, 8 skipped in 53.5s.
Trying master.chromium
Trying master.chromium.chrome
Trying master.chromium.chromiumos
Trying master.chromium.flaky
Trying master.chromium.fyi
Trying master.chromium.git
Trying master.chromium.gpu
Trying master.chromium.lkgr
Trying master.chromium.memory.fyi
Trying master.chromium.perf
Trying master.chromium.perf_av
Trying master.chromium.pyauto
Trying master.chromium.swarm
Trying master.chromium.webkit
Trying master.chromiumos
Trying master.client.nacl
Trying master.client.nacl.branch.irt
Trying master.client.nacl.chrome
Trying master.client.nacl.llvm
Trying master.client.nacl.ports
Trying master.client.nacl.ppapi
Trying master.client.nacl.sdk
Trying master.client.nacl.toolchain
Trying master.client.omaha
Trying master.client.pagespeed
Trying master.client.v8
Trying master.client.webm
Trying master.tryserver.chromium
2011-11-27 19:49:47-0800 [-] reactor class: <class
'twisted.internet.selectreactor.SelectReactor'>
2011-11-27 19:49:47-0800 [-] Creating BuildMaster -- buildbot.version: 0.7.12
2011-11-27 19:49:47-0800 [-] loading configuration from
/mnt/data/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium/master.cfg
2011-11-27 19:49:47-0800 [-] error while parsing config file
2011-11-27 19:49:47-0800 [-] error during loadConfig
2011-11-27 19:49:47-0800 [-] Unhandled Error
	Traceback (most recent call last):
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/twisted_8_1/twisted/scripts/_twistd_unix.py",
line 310, in startApplication
	    app.startApplication(application, not self.config['no_save'])
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/twisted_8_1/twisted/application/app.py",
line 635, in startApplication
	    service.IService(application).startService()
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/twisted_8_1/twisted/application/service.py",
line 260, in startService
	    service.startService()
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/buildbot_7_12/buildbot/master.py",
line 432, in startService
	    self.loadTheConfigFile()
	--- <exception caught here> ---
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/buildbot_7_12/buildbot/master.py",
line 488, in loadTheConfigFile
	    self.loadConfig(f)
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/third_party/buildbot_7_12/buildbot/master.py",
line 506, in loadConfig
	    exec f in localDict
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium/master.cfg",
line 888, in <module>
	    short_name='x86',
	  File
"/mnt/data/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium/master.cfg",
line 138, in CreateCrosBuilder
	    builder_factory = chromeos_factory.ChromeCbuildbotFactory(
	exceptions.AttributeError: 'module' object has no attribute
'ChromeCbuildbotFactory'

Trying master.tryserver.chromiumos
Trying master.tryserver.nacl


Presubmit checks took 80.5s to calculate.

[commit-bot: I haz the power, 2011-11-28 03:57:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sosa@chromium.org/8669004/7003

[commit-bot: I haz the power, 2011-11-28 03:59:16]

Presubmit check for 8669004-7003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  build/scripts/master/factory/chromeos_factory.py, line 44, 85 chars

Presubmit checks took 87.7s to calculate.

[commit-bot: I haz the power, 2011-11-28 04:04:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sosa@chromium.org/8669004/9002

[commit-bot: I haz the power, 2011-11-28 04:05:58]

Change committed as 111671