Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: scripts/master/chromeos_revision_source.py

Issue 8669004: Add arm/tegra2 CQ builders and major cleanup of dead code in chromeos_factory. (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/build
Patch Set: 80 Char nit fix, ran presubmit check locally and saw it pass Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.tryserver.chromium/master.cfg ('k') | scripts/master/factory/chromeos_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/chromeos_revision_source.py
diff --git a/scripts/master/chromeos_revision_source.py b/scripts/master/chromeos_revision_source.py
deleted file mode 100644
index c0896732e224da55fd97cfeb3ed75119e870b5e5..0000000000000000000000000000000000000000
--- a/scripts/master/chromeos_revision_source.py
+++ /dev/null
@@ -1,47 +0,0 @@
-# Copyright (c) 2010 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Module for chromium-os-specific git source that dumps revisions."""
-
-import copy
-
-from buildbot.steps import source
-from buildbot.process import buildstep
-
-# Relative path to revision file for cbuildbot.
-PFQ_REVISION_FILE = 'chromite/buildbot/revisions.pfq'
-
-class GitRevisionDropper(source.Source):
- """Drops a list of revisions from multiple git repositories."""
-
- name = 'gitrevisiondropper'
-
- def computeSourceRevision(self, changes):
- """Creates a list of revision numbers. Revision numbers coming from
- cros git hooks are folder_name:revision.
-
- This is a hook method provided by the parent source.Source class and
- default implementation in source.Source returns None. Return value of this
- method is be used to set 'revision' argument value for startVC() method."""
- revision_list = ''
- if not changes:
- return None
-
- def GrabRevision(change):
- """Handle revision == None or any invalid value."""
- return '%s@%s' % (change.repository, change.revision)
-
- for change in changes:
- revision = GrabRevision(change)
- revision_list = '%s %s' % (revision_list, revision)
- revision_list = revision_list.strip()
- return revision_list
-
- def startVC(self, branch, revision, patch):
- """Drops a source stamp for other steps"""
- args = copy.copy(self.args)
- args['command'] = 'echo "%s" > %s' % (revision, PFQ_REVISION_FILE)
- # Shell is defined by buildbot.slave.SlaveShellCommand.
- cmd = buildstep.LoggedRemoteCommand("shell", args)
- self.startCommand(cmd, [])
« no previous file with comments | « masters/master.tryserver.chromium/master.cfg ('k') | scripts/master/factory/chromeos_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698