Add PluginInstaller to encapsulate information about a missing plug-in.

chrome/browser/plugin_observer.h

Index: chrome/browser/plugin_observer.h
diff --git a/chrome/browser/plugin_observer.h b/chrome/browser/plugin_observer.h
index a8a27066725e8d61e804af370eb17be3477a02e4..2612e5293137445c84d5fb9c3a789ccc89a0e170 100644
--- a/chrome/browser/plugin_observer.h
+++ b/chrome/browser/plugin_observer.h
@@ -11,6 +11,7 @@
 
 class GURL;
 class InfoBarDelegate;
+class PluginInstaller;
 class TabContentsWrapper;
 
 class PluginObserver : public TabContentsObserver {
@@ -27,17 +28,14 @@ class PluginObserver : public TabContentsObserver {
 
   void FoundMissingPlugin(int placeholder_id,
                           const std::string& mime_type,
-                          const GURL& url,
-                          const string16& name,
-                          bool display_url);
+                          PluginInstaller* installer);

[battre, 2011/11/30 14:10:06]

const PluginInstaller*?

   void DidNotFindMissingPlugin(int placeholder_id,
                                const std::string& mime_type);
-  void InstallMissingPlugin(const GURL& url, bool display_url);
+  void InstallMissingPlugin(PluginInstaller* installer);

[battre, 2011/11/30 14:10:06]

same here?

[Bernhard Bauer, 2011/11/30 14:29:23]

Hm, I'm not sure if that's worth it, because once we have state in the
PluginInstaller, installing a plug-in will change it, so I'd need to make it
non-const again.

 
   base::WeakPtrFactory<PluginObserver> weak_ptr_factory_;
 
   TabContentsWrapper* tab_contents_;
-  scoped_ptr<InfoBarDelegate> plugin_installer_;  // Lazily created.
 
   DISALLOW_COPY_AND_ASSIGN(PluginObserver);
 };