Add PluginInstaller to encapsulate information about a missing plug-in.

chrome/browser/plugin_observer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLUGIN_OBSERVER_H_
 #define CHROME_BROWSER_PLUGIN_OBSERVER_H_
 #pragma once
 
 #include "base/memory/weak_ptr.h"
 #include "content/browser/tab_contents/tab_contents_observer.h"
 
 class GURL;
 class InfoBarDelegate;
+class PluginInstaller;
 class TabContentsWrapper;
 
 class PluginObserver : public TabContentsObserver {
  public:
   explicit PluginObserver(TabContentsWrapper* tab_contents);
   virtual ~PluginObserver();
 
   // IPC::Channel::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
  private:
   void OnBlockedOutdatedPlugin(const string16& name, const GURL& update_url);
   void OnFindMissingPlugin(int placeholder_id, const std::string& mime_type);
 
   void FoundMissingPlugin(int placeholder_id,
                           const std::string& mime_type,
-                          const GURL& url,
-                          const string16& name,
-                          bool display_url);
+                          PluginInstaller* installer);

[battre, 2011/11/30 14:10:06]

const PluginInstaller*?

   void DidNotFindMissingPlugin(int placeholder_id,
                                const std::string& mime_type);
-  void InstallMissingPlugin(const GURL& url, bool display_url);
+  void InstallMissingPlugin(PluginInstaller* installer);

[battre, 2011/11/30 14:10:06]

same here?

[Bernhard Bauer, 2011/11/30 14:29:23]

Hm, I'm not sure if that's worth it, because once we have state in the
PluginInstaller, installing a plug-in will change it, so I'd need to make it
non-const again.

 
   base::WeakPtrFactory<PluginObserver> weak_ptr_factory_;
 
   TabContentsWrapper* tab_contents_;
-  scoped_ptr<InfoBarDelegate> plugin_installer_;  // Lazily created.
 
   DISALLOW_COPY_AND_ASSIGN(PluginObserver);
 };
 
 #endif  // CHROME_BROWSER_PLUGIN_OBSERVER_H_