src/ic-arm.cc - Issue 8656: In my final round of refactoring, I accidentally broke my string...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic-arm.cc

Issue 8656: In my final round of refactoring, I accidentally broke my string... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic-arm.cc

===================================================================

--- src/ic-arm.cc (revision 621)

+++ src/ic-arm.cc (working copy)

@@ -190,7 +190,8 @@

__ ldr(r0, MemOperand(sp, 0));

- // Check if the object is a string.

+ // Check if the object is a string leaving the instance type in the

+ // r1 register.

GenerateStringCheck(masm, r0, r1, r3, &miss, &check_wrapper);

// Load length directly from the string.

@@ -204,7 +205,7 @@

// Check if the object is a JSValue wrapper.

__ bind(&check_wrapper);

- __ cmp(r0, Operand(JS_VALUE_TYPE));

+ __ cmp(r1, Operand(JS_VALUE_TYPE));

__ b(ne, &miss);

// Check if the wrapped value is a string and load the length

« no previous file with comments | « no previous file | src/stub-cache-ia32.cc » ('j') | no next file with comments »