Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: src/stub-cache-ia32.cc

Issue 8656: In my final round of refactoring, I accidentally broke my string... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic-arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/stub-cache-ia32.cc
===================================================================
--- src/stub-cache-ia32.cc (revision 621)
+++ src/stub-cache-ia32.cc (working copy)
@@ -185,7 +185,8 @@
Label* miss) {
Label load_length, check_wrapper;
- // Check if the object is a string.
+ // Check if the object is a string leaving the instance type in the
+ // scratch register.
GenerateStringCheck(masm, receiver, scratch, miss, &check_wrapper);
// Load length directly from the string.
@@ -200,7 +201,7 @@
// Check if the object is a JSValue wrapper.
__ bind(&check_wrapper);
- __ cmp(receiver, JS_VALUE_TYPE);
+ __ cmp(scratch, JS_VALUE_TYPE);
__ j(not_equal, miss, not_taken);
// Check if the wrapped value is a string and load the length
« no previous file with comments | « src/ic-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698