Reland restrict extension features based on the extension type.

chrome/common/extensions/extension_constants.cc

Index: chrome/common/extensions/extension_constants.cc
diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc
index 85bfd52a2eb1505d9ee10e781b41dc47eab957c8..ea0f1da216b0d86b27aae19ee93b2576d8e5bfe1 100644
--- a/chrome/common/extensions/extension_constants.cc
+++ b/chrome/common/extensions/extension_constants.cc
@@ -165,8 +165,8 @@ const char* kExpectString = "Expect string value.";
 const char* kExperimentalFlagRequired =
     "Loading extensions with 'experimental' permission requires"
     " --enable-experimental-extension-apis command line flag.";
-const char* kHostedAppsCannotIncludeExtensionFeatures =
-    "Hosted apps cannot use the extension feature '*'.";
+const char* kFeatureNotAllowed =
+    "Access to '*' denied.";

[Aaron Boodman, 2011/11/23 01:45:25]

Would be nice to have a slightly more descriptive error, like:

Feature 'foo' is not allowed in this type of manifest.

[jstritar, 2011/11/28 23:09:56]

Done.

 const char* kInvalidAllFrames =
     "Invalid value for 'content_scripts[*].all_frames'.";
 const char* kInvalidBackground =
@@ -426,8 +426,6 @@ const char* kReservedMessageFound =
 const char* kSidebarExperimental =
     "You must request the 'experimental' permission in order to use the"
     " Sidebar API.";
-const char* kThemesCannotContainExtensions =
-    "A theme cannot contain extensions code.";
 #if defined(OS_CHROMEOS)
 const char* kIllegalPlugins =
     "Extensions cannot install plugins on Chrome OS";