Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 8654001: Reland restrict extension features based on the extension type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/extension_constants.cc ('K') | « chrome/common/extensions/extension_constants.cc ('k') | chrome/common/extensions/extension_messages.cc » ('j') | chrome/common/extensions/manifest_value.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_manifests_unittest.cc
diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc
index 4eac8133d6e552288822ebb55f13a5ef66a62ffa..4762e8665035d1e8cc352879e1f65488ea492bcd 100644
--- a/chrome/common/extensions/extension_manifests_unittest.cc
+++ b/chrome/common/extensions/extension_manifests_unittest.cc
@@ -589,7 +589,7 @@ TEST_F(ExtensionManifestTest, Sidebar) {
TEST_F(ExtensionManifestTest, DisallowHybridApps) {
LoadAndExpectError("disallow_hybrid_1.json",
ExtensionErrorUtils::FormatErrorMessage(
- errors::kHostedAppsCannotIncludeExtensionFeatures,
+ errors::kFeatureNotAllowed,
keys::kBrowserAction));
LoadAndExpectError("disallow_hybrid_2.json",
errors::kBackgroundPermissionNeeded);
@@ -735,8 +735,14 @@ TEST_F(ExtensionManifestTest, NormalizeIconPaths) {
TEST_F(ExtensionManifestTest, DisallowMultipleUISurfaces) {
LoadAndExpectError("multiple_ui_surfaces_1.json", errors::kOneUISurfaceOnly);
- LoadAndExpectError("multiple_ui_surfaces_2.json", errors::kOneUISurfaceOnly);
- LoadAndExpectError("multiple_ui_surfaces_3.json", errors::kOneUISurfaceOnly);
+ LoadAndExpectError("multiple_ui_surfaces_2.json",
+ ExtensionErrorUtils::FormatErrorMessage(
+ errors::kFeatureNotAllowed,
+ keys::kBrowserAction));
+ LoadAndExpectError("multiple_ui_surfaces_3.json",
+ ExtensionErrorUtils::FormatErrorMessage(
+ errors::kFeatureNotAllowed,
+ keys::kBrowserAction));
}
TEST_F(ExtensionManifestTest, ParseHomepageURLs) {
« chrome/common/extensions/extension_constants.cc ('K') | « chrome/common/extensions/extension_constants.cc ('k') | chrome/common/extensions/extension_messages.cc » ('j') | chrome/common/extensions/manifest_value.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698