Issue 8638004: Revert 111083 - Revert 111080 - Remove Task inheritance in clipboard code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8638004: Revert 111083 - Revert 111080 - Remove Task inheritance in clipboard code." (Closed)

Created:
9 years, 1 month ago by dcheng

Modified:
9 years, 1 month ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert 111083 - Revert 111080 - Remove Task inheritance in clipboard code." In one instance, we can simply use currying to remove the need to inherit from Task; in the other, we retain the wrapper since it wraps an Objective-C call. Also remove an overload of ui::Clipboard::WriteObjects that's never used. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8606002 TBR=dcheng@chromium.org Review URL: http://codereview.chromium.org/8634002 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111107

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -40 lines)			Patch
M	content/browser/renderer_host/clipboard_message_filter.cc	View	4 chunks	+9 lines, -20 lines	0 comments	Download
M	content/browser/renderer_host/clipboard_message_filter_mac.mm	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	ui/base/clipboard/clipboard.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/base/clipboard/clipboard_aurax11.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/base/clipboard/clipboard_mac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/clipboard/clipboard_win.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download