Remove Task inheritance in clipboard code.

Remove Task inheritance in clipboard code.

In one instance, we can simply use currying to remove the need to
inherit from Task; in the other, we retain the wrapper since it wraps an
Objective-C call. Also remove an overload of ui::Clipboard::WriteObjects
that's never used.

BUG=none
TEST=trybots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111080

[dcheng, 2011-11-21 01:05:58]

tony for the main review and ajwong for some new callback questions:
- Is there an equivalent to base::Owned() that exposes the parameter as a const
ref?
- Is there a better way than using a wrapper class for Objective-C methods?

[awong, 2011-11-21 20:16:12]

LGTM

There isn't a way to convert from a bound pointer into a const&.  I think it's
probably too much complexity to add something like that. :(

As for the objective-c question, since scoped_nsobject<> doesn't have a copy
constructor, then I think you need a wrapper class.  There's a related
discussion about how to specify ownership transfer for scoped_xxx smart pointers
going on between Darin, Will, Fred, and I.  It's possible that you could just
take the scoped_nsobject<> as the parameter type in the future, but it has not
come to a resolution yet.

Darin

[tony, 2011-11-21 21:58:48]

LGTM, but you'll probably need some content and ui owners.

[dcheng, 2011-11-21 22:03:51]

+jam for more content approvals.

[jam, 2011-11-21 23:48:28]

content lgtm

http://codereview.chromium.org/8606002/diff/4003/content/browser/renderer_hos...
File content/browser/renderer_host/clipboard_message_filter.cc (right):

http://codereview.chromium.org/8606002/diff/4003/content/browser/renderer_hos...
content/browser/renderer_host/clipboard_message_filter.cc:31: DCHECK(objects);
this is gratuitous, if someone passes in null let it crash when it gets used.
but we avoid null dchecking parameters as a convention

[commit-bot: I haz the power, 2011-11-22 00:02:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/8606002/9002

[commit-bot: I haz the power, 2011-11-22 00:02:53]

Presubmit check for 8606002-9002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/base/clipboard/clipboard_mac.mm,ui/base/clipboard/clipboard.h,ui/base/clipboard/clipboard_win.cc

Presubmit checks took 1.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[dcheng, 2011-11-22 00:04:57]

+sky for approval for ui/base/* changes.

[sky, 2011-11-22 00:29:55]

LGTM

[commit-bot: I haz the power, 2011-11-22 00:33:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/8606002/9002

[commit-bot: I haz the power, 2011-11-22 02:22:26]

Change committed as 111080