Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 8637023: [Sync] Ensure failed datatypes handler preserves error location. (Closed)

Created:
9 years, 1 month ago by Nicolas Zea
Modified:
9 years ago
Reviewers:
lipalani1
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Ensure failed datatypes handler preserves error location. BUG=105139 TEST=trigger an error during model association, inspect about:sync to ensure line numbers are displayed in error message. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112375

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/sync/failed_datatypes_handler.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nicolas Zea
PTAL
9 years, 1 month ago (2011-11-22 19:47:44 UTC) #1
Nicolas Zea
ping!
9 years, 1 month ago (2011-11-23 20:51:38 UTC) #2
lipalani1
LGTM
9 years, 1 month ago (2011-11-23 21:11:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8637023/1
9 years, 1 month ago (2011-11-23 21:26:36 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/sync/failed_datatypes_handler.cc. While running patch -p1 --forward --force; patching file chrome/browser/sync/failed_datatypes_handler.cc ...
9 years, 1 month ago (2011-11-23 21:26:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8637023/7001
9 years ago (2011-11-29 23:41:17 UTC) #6
commit-bot: I haz the power
Try job failure for 8637023-7001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 00:39:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8637023/11001
9 years ago (2011-12-01 00:03:09 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-01 02:25:08 UTC) #9
Change committed as 112375

Powered by Google App Engine
This is Rietveld 408576698