Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/sync/failed_datatypes_handler.cc

Issue 8637023: [Sync] Ensure failed datatypes handler preserves error location. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix conflict Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/failed_datatypes_handler.cc
diff --git a/chrome/browser/sync/failed_datatypes_handler.cc b/chrome/browser/sync/failed_datatypes_handler.cc
index c5dc60f12210c2a151b25c3075e0aac44f979746..d1feb347b0b2d6eda685bc146abeda80acf086b9 100644
--- a/chrome/browser/sync/failed_datatypes_handler.cc
+++ b/chrome/browser/sync/failed_datatypes_handler.cc
@@ -44,15 +44,14 @@ void FailedDatatypesHandler::OnUserChoseDatatypes() {
}
std::string FailedDatatypesHandler::GetErrorString() const {
- std::string message;
+ std::string message = "Sync configuration failed when starting ";
for (std::list<SyncError>::const_iterator it = errors_.begin();
it != errors_.end(); ++it) {
if (it != errors_.begin()) {
message += ", ";
}
- message += "Sync configuration failed when starting "
- + std::string(syncable::ModelTypeToString(it->type()))
- + ": " + it->message();
+ message += std::string(syncable::ModelTypeToString(it->type())) + " " +
+ it->location().ToString() + ": " + it->message();
}
return message;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698