Issue 8635003: Fix HEAP_PROFILE_MMAP in google-perftools.

Issue 8635003: Fix HEAP_PROFILE_MMAP in google-perftools. (Closed)

Created:
9 years, 1 month ago by Dai Mikurube (NOT FULLTIME)

Modified:
8 years, 10 months ago

Reviewers:

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix HEAP_PROFILE_MMAP in google-perftools. 1. The same change as http://code.google.com/p/google-perftools/issues/detail?id=384 except for the function names of RecordAlloc and RecordAllocWithStack. 2. Some redundant comments are included in this patch. This patch is originally from http://codereview.chromium.org/7865021/. BUG=none TEST=none

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the bug in HEAP_PROFILE_MMAP. #

Patch Set 3 : Fixed. #

Patch Set 4 : Fixed some failures. #

Patch Set 5 : increase the size of the sorted bucket list for safety. #

Patch Set 6 : Fixed and refactored. #

Patch Set 7 : Removed and modified comments about HeapProfileTable::total(). #

Patch Set 8 : Updated. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -99 lines)			Patch
M	third_party/tcmalloc/chromium/src/heap-profile-table.h	View	1 2 3 4 5 6 7	6 chunks	+46 lines, -13 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/heap-profile-table.cc	View	1 2 3 4 5 6 7	16 chunks	+148 lines, -54 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/heap-profiler.cc	View	1 2 3 4 5 6 7	2 chunks	+6 lines, -32 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/memory_region_map.h	View	1 2 3 4 5	2 chunks	+9 lines, -0 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/memory_region_map.cc	View	1	3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dai Mikurube (NOT FULLTIME)

http://codereview.chromium.org/8635003/diff/1/third_party/tcmalloc/chromium/src/heap-profiler.cc File third_party/tcmalloc/chromium/src/heap-profiler.cc (right): http://codereview.chromium.org/8635003/diff/1/third_party/tcmalloc/chromium/src/heap-profiler.cc#newcode220 third_party/tcmalloc/chromium/src/heap-profiler.cc:220: AddRemoveMMapDataLocked(ADD); mmap() log is merged into malloc() log here. ...

9 years ago (2011-12-01 07:56:42 UTC) #1

Dai Mikurube (NOT FULLTIME)

See: updating the tcmalloc vender branch at http://codereview.chromium.org/7430002

9 years ago (2011-12-07 05:20:13 UTC) #2

Dai Mikurube (NOT FULLTIME)

9 years ago (2011-12-13 04:47:19 UTC) #3

Updated the fix.  This change is the same as
http://code.google.com/p/google-perftools/issues/detail?id=384 except for the
function names of RecordAlloc and RecordAllocWithStack.

Expand Messages | Collapse Messages