Make the profile buffer larger in third_party/tcmalloc/chromium.

Make the profile buffer larger in third_party/tcmalloc/chromium.

This patch is originally from http://codereview.chromium.org/7865021/. 


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115805

[Alexander Potapenko, 2011-12-20 13:19:38]

http://codereview.chromium.org/8634005/diff/6003/third_party/tcmalloc/chromiu...
File third_party/tcmalloc/chromium/src/heap-profiler.cc (right):

http://codereview.chromium.org/8634005/diff/6003/third_party/tcmalloc/chromiu...
third_party/tcmalloc/chromium/src/heap-profiler.cc:152: static const int
kProfileBufferSize = 5 << 20;
There should be some comment that describes this change.

[Dai Mikurube (NOT FULLTIME), 2011-12-21 05:32:45]

Thanks.

http://codereview.chromium.org/8634005/diff/6003/third_party/tcmalloc/chromiu...
File third_party/tcmalloc/chromium/src/heap-profiler.cc (right):

http://codereview.chromium.org/8634005/diff/6003/third_party/tcmalloc/chromiu...
third_party/tcmalloc/chromium/src/heap-profiler.cc:152: static const int
kProfileBufferSize = 5 << 20;
On 2011/12/20 13:19:38, Alexander Potapenko wrote:
> There should be some comment that describes this change.

Done.

[Alexander Potapenko, 2011-12-22 10:40:11]

LGTM

[jar (doing other things), 2011-12-22 16:02:09]

http://codereview.chromium.org/8634005/diff/12001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/heap-profiler.cc (right):

http://codereview.chromium.org/8634005/diff/12001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/heap-profiler.cc:153: // 5 << 20 since larger
buffers are requried for deeper profiling in Chromium.
Could you provide a comment that makes it clear when this amount of memory is
allocated and used? 1 Meg is already a lot, and 5M is of course a whole lot.

I started to read the code to try to track this down, but IMO, it would be nice
to have the comment here.

[Dai Mikurube (NOT FULLTIME), 2011-12-26 03:58:26]

Hi Jim,

Thank you for the comments.  Modified it.

http://codereview.chromium.org/8634005/diff/12001/third_party/tcmalloc/chromi...
File third_party/tcmalloc/chromium/src/heap-profiler.cc (right):

http://codereview.chromium.org/8634005/diff/12001/third_party/tcmalloc/chromi...
third_party/tcmalloc/chromium/src/heap-profiler.cc:153: // 5 << 20 since larger
buffers are requried for deeper profiling in Chromium.
On 2011/12/22 16:02:09, jar wrote:
> Could you provide a comment that makes it clear when this amount of memory is
> allocated and used? 1 Meg is already a lot, and 5M is of course a whole lot.
> 
> I started to read the code to try to track this down, but IMO, it would be
nice
> to have the comment here.
> 

Done.

[jar (doing other things), 2011-12-26 10:19:05]

lgtm

[commit-bot: I haz the power, 2011-12-27 01:59:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/8634005/19001

[Dai Mikurube (NOT FULLTIME), 2011-12-27 02:26:44]

Thanks.  I checked the "Commit" box.

[commit-bot: I haz the power, 2011-12-27 02:48:56]

Try job failure for 8634005-19001 (retry) on linux_rel for steps "browser_tests,
ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-27 02:51:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/8634005/19001

[commit-bot: I haz the power, 2011-12-27 04:05:49]

Change committed as 115805