Fix player_x11 crash with --audio; new audio renderer.

Replaces the broken raw stream based audio renderer with one based on AudioOutputController.

I looked into switching it over to the low latency based controller, but the setup for low latency is pretty significant. Large portions of AudioRenderImpl and AudioRendererHost would have to be cribbed and tweaked.

BUG=96789
TEST=Ran player_x11 --audio


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111437

[DaleCurtis, 2011-11-22 04:06:24]

PTAL.

[scherkus (not reviewing), 2011-11-23 01:40:22]

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.cc (right):

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:13: // This is an arbitrary number.
Taken from audio_output_controoler_unittest.
replace this with bits_per_channel

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:74: // Modeled after
audio_output_controller_unittest.
nix this comment

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:77:
ChannelLayoutToChannelCount(channel_layout) * kBitsPerSample / 8;
bits_per_channel should be good here

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.h (right):

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.h:14: // See
src/chrome/renderer/media/audio_renderer_impl.h for chrome's
want to update this to chrome -> content

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.h:63: uint8* buffer_;
scoped_array<uint8> buffer_

this way it'll delete itself!

base/memory/scoped_ptr.h

[DaleCurtis, 2011-11-23 02:30:06]

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.cc (right):

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:13: // This is an arbitrary number.
Taken from audio_output_controoler_unittest.
On 2011/11/23 01:40:22, scherkus wrote:
> replace this with bits_per_channel

Done.

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:74: // Modeled after
audio_output_controller_unittest.
On 2011/11/23 01:40:22, scherkus wrote:
> nix this comment

Done.

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:77:
ChannelLayoutToChannelCount(channel_layout) * kBitsPerSample / 8;
On 2011/11/23 01:40:22, scherkus wrote:
> bits_per_channel should be good here

Done.

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.h (right):

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.h:14: // See
src/chrome/renderer/media/audio_renderer_impl.h for chrome's
On 2011/11/23 01:40:22, scherkus wrote:
> want to update this to chrome -> content

Done.

http://codereview.chromium.org/8631001/diff/2001/media/filters/reference_audi...
media/filters/reference_audio_renderer.h:63: uint8* buffer_;
On 2011/11/23 01:40:22, scherkus wrote:
> scoped_array<uint8> buffer_
> 
> this way it'll delete itself!
> 
> base/memory/scoped_ptr.h

Done.

[scherkus (not reviewing), 2011-11-23 02:37:38]

http://codereview.chromium.org/8631001/diff/6001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.cc (right):

http://codereview.chromium.org/8631001/diff/6001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:77:
ChannelLayoutToChannelCount(channel_layout) * kBitsPerChannel / 8;
wait using bits_per_channel (passed in) doesn't work?

[DaleCurtis, 2011-11-23 02:41:22]

http://codereview.chromium.org/8631001/diff/6001/media/filters/reference_audi...
File media/filters/reference_audio_renderer.cc (right):

http://codereview.chromium.org/8631001/diff/6001/media/filters/reference_audi...
media/filters/reference_audio_renderer.cc:77:
ChannelLayoutToChannelCount(channel_layout) * kBitsPerChannel / 8;
Works fine; I'm an idiot. Done.

On 2011/11/23 02:37:38, scherkus wrote:
> wait using bits_per_channel (passed in) doesn't work?

[scherkus (not reviewing), 2011-11-23 02:44:37]

assuming it all works and has is in AV sync then LGTM

[commit-bot: I haz the power, 2011-11-23 20:01:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/8631001/3003

[commit-bot: I haz the power, 2011-11-23 20:46:04]

Try job failure for 8631001-3003 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-23 21:00:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/8631001/12001

[commit-bot: I haz the power, 2011-11-23 23:33:16]

Change committed as 111437