Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: media/filters/reference_audio_renderer.h

Issue 8631001: Fix player_x11 crash with --audio; new audio renderer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix compile warning. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/reference_audio_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/reference_audio_renderer.h
diff --git a/media/filters/reference_audio_renderer.h b/media/filters/reference_audio_renderer.h
index e8b9921f230f7eb752491e82b5a28c73a34ccecd..9ab9b261792b53f8512661cf5d2314e7f293c8e2 100644
--- a/media/filters/reference_audio_renderer.h
+++ b/media/filters/reference_audio_renderer.h
@@ -11,21 +11,17 @@
//
// Note: THIS IS NOT THE AUDIO RENDERER USED IN CHROME.
//
-// See src/chrome/renderer/media/audio_renderer_impl.h for chrome's
+// See src/content/renderer/media/audio_renderer_impl.h for chrome's
// implementation.
-#include <deque>
-
-#include "media/audio/audio_io.h"
-#include "media/base/buffers.h"
-#include "media/base/filters.h"
+#include "media/audio/audio_output_controller.h"
#include "media/filters/audio_renderer_base.h"
namespace media {
class MEDIA_EXPORT ReferenceAudioRenderer
: public AudioRendererBase,
- public AudioOutputStream::AudioSourceCallback {
+ public AudioOutputController::EventHandler {
public:
ReferenceAudioRenderer();
virtual ~ReferenceAudioRenderer();
@@ -36,12 +32,14 @@ class MEDIA_EXPORT ReferenceAudioRenderer
// AudioRenderer implementation.
virtual void SetVolume(float volume) OVERRIDE;
- // AudioSourceCallback implementation.
- virtual uint32 OnMoreData(AudioOutputStream* stream, uint8* dest,
- uint32 len,
- AudioBuffersState buffers_state) OVERRIDE;
- virtual void OnClose(AudioOutputStream* stream);
- virtual void OnError(AudioOutputStream* stream, int code) OVERRIDE;
+ // AudioController::EventHandler implementation.
+ virtual void OnCreated(AudioOutputController* controller) OVERRIDE;
+ virtual void OnPlaying(AudioOutputController* controller) OVERRIDE;
+ virtual void OnPaused(AudioOutputController* controller) OVERRIDE;
+ virtual void OnError(AudioOutputController* controller,
+ int error_code) OVERRIDE;
+ virtual void OnMoreData(AudioOutputController* controller,
+ AudioBuffersState buffers_state) OVERRIDE;
protected:
// AudioRendererBase implementation.
@@ -51,10 +49,18 @@ class MEDIA_EXPORT ReferenceAudioRenderer
virtual void OnStop() OVERRIDE;
private:
- // Audio output stream device.
- AudioOutputStream* stream_;
int bytes_per_second_;
+ // AudioOutputController::Close callback.
+ virtual void OnClose();
+
+ // Audio output controller.
+ scoped_refptr<media::AudioOutputController> controller_;
+
+ // Audio buffer.
+ int buffer_capacity_;
+ scoped_array<uint8> buffer_;
+
DISALLOW_COPY_AND_ASSIGN(ReferenceAudioRenderer);
};
« no previous file with comments | « no previous file | media/filters/reference_audio_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698