Center the disconnect window at the bottom of the screen.

Center the disconnect window at the bottom of the screen.

BUG=101178
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111317

[Jamie, 2011-11-21 23:45:32]

Dave, PTAL.

Lambros, read and learn :)

[dmac, 2011-11-22 05:42:06]

http://codereview.chromium.org/8623006/diff/1/remoting/host/disconnect_window...
File remoting/host/disconnect_window_mac.mm (right):

http://codereview.chromium.org/8623006/diff/1/remoting/host/disconnect_window...
remoting/host/disconnect_window_mac.mm:162: int x = (desktop_rect.size.width -
window_rect.size.width) / 2;
Please use objective C naming in objective c files
desktopRect and windowRect

CGFloat x = (NSWidth(desktopRect) - NSWidth(windowRect)) / 2;
CGFloat y = NSMinY(desktopRect);

Aside from that, is there a problem that the user may start with their dock
hidden, and then a malicious remote operator could turn the dock on, and make
the local user be unable to reach the disconnect window because the dock will
block access to it? (hopefully that makes some sense).

[Jamie, 2011-11-22 21:17:06]

On 2011/11/22 05:42:06, dmac wrote:
>
http://codereview.chromium.org/8623006/diff/1/remoting/host/disconnect_window...
> File remoting/host/disconnect_window_mac.mm (right):
> 
>
http://codereview.chromium.org/8623006/diff/1/remoting/host/disconnect_window...
> remoting/host/disconnect_window_mac.mm:162: int x = (desktop_rect.size.width -
> window_rect.size.width) / 2;
> Please use objective C naming in objective c files
> desktopRect and windowRect

Done

> CGFloat x = (NSWidth(desktopRect) - NSWidth(windowRect)) / 2;
> CGFloat y = NSMinY(desktopRect);

Done

> Aside from that, is there a problem that the user may start with their dock
> hidden, and then a malicious remote operator could turn the dock on, and make
> the local user be unable to reach the disconnect window because the dock will
> block access to it? (hopefully that makes some sense).

I don't think that's a problem. The window floats above the Dock anyway.

[dmac, 2011-11-22 21:34:31]

lgtm

LGTM

[commit-bot: I haz the power, 2011-11-23 01:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/8623006/5001

[commit-bot: I haz the power, 2011-11-23 04:49:00]

Change committed as 111317