Center the disconnect window at the bottom of the screen.

remoting/host/disconnect_window_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "remoting/host/disconnect_window_mac.h"
 
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
@@ skipping 137 matching lines @@
   if ([self isRToL]) {
     // Handle right to left case
     CGFloat buttonInset = NSWidth(windowFrame) - NSMaxX(disconnectFrame);
     CGFloat buttonTextSpacing
         = NSMinX(disconnectFrame) - NSMaxX(connectedToFrame);
     disconnectFrame.origin.x = buttonInset;
     connectedToFrame.origin.x = NSMaxX(disconnectFrame) + buttonTextSpacing;
     [connectedToField_ setFrame:connectedToFrame];
     [disconnectButton_ setFrame:disconnectFrame];
   }
+
+  // Center the window at the bottom of the screen, above the dock (if present).
+  NSRect desktop_rect = [[NSScreen mainScreen] visibleFrame];
+  NSRect window_rect = [[self window] frame];
+  int x = (desktop_rect.size.width - window_rect.size.width) / 2;

[dmac, 2011/11/22 05:42:06]

Please use objective C naming in objective c files
desktopRect and windowRect

CGFloat x = (NSWidth(desktopRect) - NSWidth(windowRect)) / 2;
CGFloat y = NSMinY(desktopRect);

Aside from that, is there a problem that the user may start with their dock
hidden, and then a malicious remote operator could turn the dock on, and make
the local user be unable to reach the disconnect window because the dock will
block access to it? (hopefully that makes some sense).

+  int y = desktop_rect.origin.y;
+  [[self window] setFrameOrigin:NSMakePoint(x, y)];
 }
 
 - (void)windowWillClose:(NSNotification*)notification {
   [self stopSharing:self];
   [self autorelease];
 }
 
 @end
 
 
@@ skipping 110 matching lines @@
   path = [NSBezierPath bezierPath];
   [path moveToPoint:top];
   [path lineToPoint:bottom];
   [light setStroke];
   [path stroke];
 
   [context setShouldAntialias:alias];
 }
 
 @end