Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 8622004: Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the brows... (Closed)

Created:
9 years, 1 month ago by apatrick_chromium
Modified:
9 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation. Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before. PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided. I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency. I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations. Original Review URL: http://codereview.chromium.org/8060045 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111246

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -261 lines) Patch
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 5 chunks +10 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_mac.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view.h View 4 chunks +10 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +25 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +8 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 6 chunks +51 lines, -2 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 3 chunks +1 line, -13 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 3 chunks +3 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 7 chunks +16 lines, -72 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 5 chunks +12 lines, -43 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 6 chunks +46 lines, -0 lines 1 comment Download
M content/common/gpu/image_transport_surface.cc View 6 chunks +94 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 8 chunks +29 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 4 chunks +10 lines, -0 lines 0 comments Download
A + content/common/gpu/image_transport_surface_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 3 chunks +5 lines, -9 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_win.cc View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-11-23 19:16:23 UTC) #1
http://codereview.chromium.org/8622004/diff/1/content/common/gpu/image_transp...
File content/common/gpu/image_transport_surface.h (right):

http://codereview.chromium.org/8622004/diff/1/content/common/gpu/image_transp...
content/common/gpu/image_transport_surface.h:152: virtual void Destroy();
FYI, please tag all overriding functions with OVERRIDE. (I'm fixing this one in
a patch to come.)

Powered by Google App Engine
This is Rietveld 408576698