Issue 8621004: Revert 111018 - Rebase AvatarMenuBubbleView on the new views bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8621004: Revert 111018 - Rebase AvatarMenuBubbleView on the new views bubble. (Closed)

Created:
9 years, 1 month ago by msw

Modified:
9 years, 1 month ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 111018 - Rebase AvatarMenuBubbleView on the new views bubble. Added an std::max to prevent negative width calculation. TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE. I filed crbug.com/105014 for the placement regression on NTP. BUG=98323 TEST=The avatar menu bubble works as before. Review URL: http://codereview.chromium.org/8500004 TBR=msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111024

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -38 lines)			Patch
M	chrome/browser/ui/views/avatar_menu_bubble_view.h	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_bubble_view.cc	View	6 chunks	+24 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_button.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_button.cc	View	3 chunks	+17 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)