Rebase AvatarMenuBubbleView on the new views bubble.

Rebase AvatarMenuBubbleView on the new views bubble.
Added an std::max to prevent negative width calculation.

TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
I filed crbug.com/105014 for the placement regression on NTP.

BUG=98323
TEST=The avatar menu bubble works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111018

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111102

[msw, 2011-11-19 05:40:42]

Sail, Alice: I got started on the avatar bubble. PTAL; thanks!
We need to deprecate use of the old bubble code this week (I'm out after Tue).
Can we leave the custom bubble positioning for a followup change?

[alicet1, 2011-11-19 15:50:44]

lgtm

lg for moving to the new bubble code.

[sail, 2011-11-21 17:40:40]

lgtm

[msw, 2011-11-21 20:03:14]

Ben PTAL, we'll address the bubble placement regression in another CL ASAP.

[Ben Goodger (Google), 2011-11-21 20:23:22]

lgtm

http://codereview.chromium.org/8500004/diff/5001/chrome/browser/ui/views/avat...
File chrome/browser/ui/views/avatar_menu_button.cc (right):

http://codereview.chromium.org/8500004/diff/5001/chrome/browser/ui/views/avat...
chrome/browser/ui/views/avatar_menu_button.cc:156:
views::BubbleBorder::TOP_LEFT, bounds, browser_);
4-space indent

[msw, 2011-11-21 20:39:01]

Done; landing.

http://codereview.chromium.org/8500004/diff/5001/chrome/browser/ui/views/avat...
File chrome/browser/ui/views/avatar_menu_button.cc (right):

http://codereview.chromium.org/8500004/diff/5001/chrome/browser/ui/views/avat...
chrome/browser/ui/views/avatar_menu_button.cc:156:
views::BubbleBorder::TOP_LEFT, bounds, browser_);
On 2011/11/21 20:23:22, Ben Goodger (Google) wrote:
> 4-space indent 

Done.

[commit-bot: I haz the power, 2011-11-21 20:40:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/8500004/11001

[commit-bot: I haz the power, 2011-11-21 22:46:08]

Change committed as 111018