Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 8620001: Cleanup pass from Cloud Print Proxy policy implementation. (Closed)

Created:
9 years, 1 month ago by Scott Byer
Modified:
9 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Cleanup pass from Cloud Print Proxy policy check implementation. See original CL at http://codereview.chromium.org/8438020/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -29 lines) Patch
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/service/service_process_control.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Byer
http://codereview.chromium.org/8438020/diff/16002/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc#newcode168 Done. http://codereview.chromium.org/8438020/diff/16002/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc#newcode186 Done http://codereview.chromium.org/8438020/diff/16002/chrome/browser/service/service_process_control.cc#newcode82 Done http://codereview.chromium.org/8438020/diff/16002/chrome/browser/service/service_process_control.h#newcode54 Done
9 years, 1 month ago (2011-11-21 22:50:41 UTC) #1
Peter Kasting
LGTM
9 years, 1 month ago (2011-11-21 23:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/8620001/1
9 years, 1 month ago (2011-11-22 00:00:09 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 01:25:14 UTC) #4
Change committed as 111068

Powered by Google App Engine
This is Rietveld 408576698