chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 8620001: Cleanup pass from Cloud Print Proxy policy implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 8620001: Cleanup pass from Cloud Print Proxy policy implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc ('k') | chrome/browser/printing/cloud_print/virtual_driver_install_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

index 4f69a353feaf964cf8a410994afedeb791ab26a4..efa0088221585cd06e67afaa78d9c36b87265f8d 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

@@ -34,7 +34,7 @@ class MockServiceProcessControl : public ServiceProcessControl {

MockServiceProcessControl() : connected_(false) { }

- MOCK_CONST_METHOD0(is_connected, bool());

+ MOCK_CONST_METHOD0(IsConnected, bool());

MOCK_METHOD2(Launch, void(const base::Closure&, const base::Closure&));

MOCK_METHOD0(Disconnect, void());

@@ -78,7 +78,7 @@ void CallTask(const base::Closure& task) {

void MockServiceProcessControl::SetConnectSuccessMockExpectations(

ServiceState service_state) {

- EXPECT_CALL(*this, is_connected()).WillRepeatedly(ReturnPointee(&connected_));

+ EXPECT_CALL(*this, IsConnected()).WillRepeatedly(ReturnPointee(&connected_));

EXPECT_CALL(*this, Launch(_, _))

.WillRepeatedly(

@@ -181,13 +181,13 @@ TEST_F(CloudPrintProxyPolicyTest, VerifyExpectations) {

mock_control.SetConnectSuccessMockExpectations(

MockServiceProcessControl::kServiceStateNone);

- EXPECT_FALSE(mock_control.is_connected());

+ EXPECT_FALSE(mock_control.IsConnected());

mock_control.Launch(base::Closure(), base::Closure());

- EXPECT_TRUE(mock_control.is_connected());

+ EXPECT_TRUE(mock_control.IsConnected());

mock_control.Launch(base::Closure(), base::Closure());

- EXPECT_TRUE(mock_control.is_connected());

+ EXPECT_TRUE(mock_control.IsConnected());

mock_control.Disconnect();

- EXPECT_FALSE(mock_control.is_connected());

+ EXPECT_FALSE(mock_control.IsConnected());

}

TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabled) {