CrOs: Remove 16 exit time destructors and 11 static initializers.

CrOs: Remove 16 exit time destructors and 11 static initializers.

BUG=101600, 94925
TEST=none
TBR=stevenjb

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110868

[Ryan Sleevi, 2011-11-20 23:10:49]

lgtm

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/abou...
File chrome/browser/ui/views/about_chrome_view.cc (left):

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/abou...
chrome/browser/ui/views/about_chrome_view.cc:60: const string16
kBeginLink(ASCIIToUTF16("BEGIN_LINK"));
Is it worth doing

const char16 kBeginLink[] = { 'B', 'E', 'G', 'I', 'N', '_', 'L', 'I', 'N', 'K'
}; ?

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/crea...
File chrome/browser/ui/views/create_application_shortcut_view.cc (right):

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/crea...
chrome/browser/ui/views/create_application_shortcut_view.cc:113: const string16
kEllipsis(ASCIIToUTF16(" ... "));
Same here (const char16 ...[] = { ' ', '.', '.', '.', ' ' }

[Nico, 2011-11-20 23:12:59]

thanks!

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/crea...
File chrome/browser/ui/views/create_application_shortcut_view.cc (right):

http://codereview.chromium.org/8609002/diff/3001/chrome/browser/ui/views/crea...
chrome/browser/ui/views/create_application_shortcut_view.cc:113: const string16
kEllipsis(ASCIIToUTF16(" ... "));
On 2011/11/20 23:10:49, Ryan Sleevi wrote:
> Same here (const char16 ...[] = { ' ', '.', '.', '.', ' ' }

I doubt this is a hotspot.

[commit-bot: I haz the power, 2011-11-20 23:13:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8609002/3001

[commit-bot: I haz the power, 2011-11-20 23:13:16]

Presubmit check for 8609002-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/chromeos/status/network_menu_icon.cc

Presubmit checks took 1.5s to calculate.

[Nico, 2011-11-20 23:15:01]

stevenjb: OWNERS approval, please.

[commit-bot: I haz the power, 2011-11-20 23:15:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8609002/3001

[commit-bot: I haz the power, 2011-11-21 00:25:16]

Change committed as 110868

[Mark Mentovai, 2011-11-21 13:40:55]

LGTM