CrOs: Remove 16 exit time destructors and 11 static initializers.

chrome/browser/ui/views/about_chrome_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/about_chrome_view.h"
 
 #if defined(OS_WIN)
 #include <commdlg.h>
 #endif  // defined(OS_WIN)
 
@@ skipping 39 matching lines @@
 #include "chrome/installer/util/install_util.h"
 #endif  // defined(OS_WIN)
 
 // The amount of vertical space separating the error label at the bottom from
 // the rest of the text.
 static const int kErrorLabelVerticalSpacing = 15;  // Pixels.
 
 namespace {
 // These are used as placeholder text around the links in the text in the about
 // dialog.
-const string16 kBeginLink(ASCIIToUTF16("BEGIN_LINK"));

[Ryan Sleevi, 2011/11/20 23:10:49]

Is it worth doing

const char16 kBeginLink[] = { 'B', 'E', 'G', 'I', 'N', '_', 'L', 'I', 'N', 'K'
}; ?

-const string16 kEndLink(ASCIIToUTF16("END_LINK"));
-const string16 kBeginLinkChr(ASCIIToUTF16("BEGIN_LINK_CHR"));
-const string16 kBeginLinkOss(ASCIIToUTF16("BEGIN_LINK_OSS"));
-const string16 kEndLinkChr(ASCIIToUTF16("END_LINK_CHR"));
-const string16 kEndLinkOss(ASCIIToUTF16("END_LINK_OSS"));
+string16 kBeginLink() {
+  return ASCIIToUTF16("BEGIN_LINK");
+}
+string16 kEndLink() {
+  return ASCIIToUTF16("END_LINK");
+}
+string16 kBeginLinkChr() {
+  return ASCIIToUTF16("BEGIN_LINK_CHR");
+}
+string16 kBeginLinkOss() {
+  return ASCIIToUTF16("BEGIN_LINK_OSS");
+}
+string16 kEndLinkChr() {
+  return ASCIIToUTF16("END_LINK_CHR");
+}
+string16 kEndLinkOss() {
+  return ASCIIToUTF16("END_LINK_OSS");
+}
 
 // Returns a substring from |text| between start and end.
 string16 StringSubRange(const string16& text, size_t start, size_t end) {
   DCHECK(end > start);
   return text.substr(start, end - start);
 }
 
 }  // namespace
 
 namespace browser {
@@ skipping 113 matching lines @@
       l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_COPYRIGHT));
   copyright_label_->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
   AddChildView(copyright_label_);
 
   main_text_label_ = new views::Label(string16());
 
   // Figure out what to write in the main label of the About box.
   string16 text = l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_LICENSE);
 
   chromium_url_appears_first_ =
-      text.find(kBeginLinkChr) < text.find(kBeginLinkOss);
+      text.find(kBeginLinkChr()) < text.find(kBeginLinkOss());
 
-  size_t link1 = text.find(kBeginLink);
+  size_t link1 = text.find(kBeginLink());
   DCHECK(link1 != string16::npos);
-  size_t link1_end = text.find(kEndLink, link1);
+  size_t link1_end = text.find(kEndLink(), link1);
   DCHECK(link1_end != string16::npos);
-  size_t link2 = text.find(kBeginLink, link1_end);
+  size_t link2 = text.find(kBeginLink(), link1_end);
   DCHECK(link2 != string16::npos);
-  size_t link2_end = text.find(kEndLink, link2);
+  size_t link2_end = text.find(kEndLink(), link2);
   DCHECK(link1_end != string16::npos);
 
   main_label_chunk1_ = text.substr(0, link1);
-  main_label_chunk2_ = StringSubRange(text, link1_end + kEndLinkOss.size(),
+  main_label_chunk2_ = StringSubRange(text, link1_end + kEndLinkOss().size(),
                                       link2);
-  main_label_chunk3_ = text.substr(link2_end + kEndLinkOss.size());
+  main_label_chunk3_ = text.substr(link2_end + kEndLinkOss().size());
 
   // The Chromium link within the main text of the dialog.
   chromium_url_ = new views::Link(
-      StringSubRange(text, text.find(kBeginLinkChr) + kBeginLinkChr.size(),
-                     text.find(kEndLinkChr)));
+      StringSubRange(text, text.find(kBeginLinkChr()) + kBeginLinkChr().size(),
+                     text.find(kEndLinkChr())));
   AddChildView(chromium_url_);
   chromium_url_->set_listener(this);
 
   // The Open Source link within the main text of the dialog.
   open_source_url_ = new views::Link(
-      StringSubRange(text, text.find(kBeginLinkOss) + kBeginLinkOss.size(),
-                     text.find(kEndLinkOss)));
+      StringSubRange(text, text.find(kBeginLinkOss()) + kBeginLinkOss().size(),
+                     text.find(kEndLinkOss())));
   AddChildView(open_source_url_);
   open_source_url_->set_listener(this);
 
 #if defined(OS_WIN)
   SkColor background_color = color_utils::GetSysSkColor(COLOR_3DFACE);
   copyright_label_->SetBackgroundColor(background_color);
   main_text_label_->SetBackgroundColor(background_color);
   chromium_url_->SetBackgroundColor(background_color);
   open_source_url_->SetBackgroundColor(background_color);
 #endif
@@ skipping 542 matching lines @@
   int height = error_label_->GetHeightForWidth(
       dialog_dimensions_.width() - (2 * views::kPanelHorizMargin)) +
           views::kRelatedControlVerticalSpacing;
   window_rect.set_height(window_rect.height() + height);
   GetWidget()->SetBounds(window_rect);
 
   return height;
 }
 
 #endif