Parse individual X.509 name components on Windows, rather than their stringified form

Parse individual X.509 name components on Windows, rather than parsing the stringified form

On Windows, rather than converting the entire certificate 
name to a string and attempting to parse out the components 
and values, iterate through the relativeDistinguishedName 
and AttributeTypeAndValue pairs to extract each name 
component.

This is to ensure that:
1) When multiple AVAs are present in an RDN, ALL AVAs are
   parsed.
2) When converting an AVA to a string, no extra escaping is
   applied.

This also fixes domainComponent parsing on OS X, so that
unittests with a domainComponent can pass.

BUG=101009, 102839
TEST=net_unittests:X509CertificateTest has two new regression
tests. Additionally, sample a variety of SSL sites and ensure no
regressions, paying attention to internationalized domains.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112650

[Ryan Sleevi, 2011-11-21 05:57:17]

wtc: PTAL.

Note, I'm working on generating some new test certificates for these tests, and
won't be using the current certificates included. These were just to make sure
the implementation was sound across the trybots - which is also why README.txt
wasn't updated.

palmer: +cc, in the event you have any strong feelings about whether or not what
the Infonotary cert is doing should be accepted.

[wtc, 2011-12-01 23:59:41]

Patch Set 3 LGTM.

Please update the CL's commit message to mention the Mac
change (to decode DomainComponent).

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_cert_types_mac.cc
File net/base/x509_cert_types_mac.cc (right):

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_cert_types_mac...
net/base/x509_cert_types_mac.cc:22: // implementation improperly encoded this on
10.6+, and even still is

Would be nice to include Apple's improper encoding of this OID
here.  Don't worry about it if it's too much work.

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_cert_types_mac...
net/base/x509_cert_types_mac.cc:33: const CSSM_OID kDomainComponent = {

Nit: kDomainComponent => kDomainComponentOID
                      or kOIDDomainComponent

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_certificate_un...
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_certificate_un...
net/base/x509_certificate_unittest.cc:416: // such as = or ", are not escaped
when parsed as individual components.

Nit: put = and " in single quotes?

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_certificate_wi...
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/8608003/diff/4002/net/base/x509_certificate_wi...
net/base/x509_certificate_win.cc:547: size_t length,

Nit: perhaps this can take CERT_NAME_BLOB* as input argument?

[commit-bot: I haz the power, 2011-12-02 05:52:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8608003/11008

[commit-bot: I haz the power, 2011-12-02 07:31:21]

Change committed as 112650