Parse individual X.509 name components on Windows, rather than their stringified form

net/base/x509_cert_types_mac.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_cert_types.h"
 
 #include <CoreServices/CoreServices.h>
 #include <Security/Security.h>
 #include <Security/SecAsn1Coder.h>
 
 #include "base/logging.h"
 #include "base/i18n/icu_string_conversions.h"
 #include "base/utf_string_conversions.h"
 
 namespace net {
 
 namespace {
 
+// The BER encoding of 0.9.2342.19200300.100.1.25.
+// On 10.6 and later this is available as CSSMOID_DomainComponent, which is an
+// external symbol from Security.framework. However, it appears that Apple's
+// implementation improperly encoded this on 10.6+, and even still is

[wtc, 2011/12/01 23:59:41]

Would be nice to include Apple's improper encoding of this OID
here.  Don't worry about it if it's too much work.

+// unavailable on 10.5, so simply including the raw BER here.
+//
+// Note: CSSM is allowed to store CSSM_OIDs in any arbitrary format desired,
+// as long as the symbols are properly exposed. The fact that Apple's
+// implementation stores it in BER is an internal implementation detail
+// observed by studying libsecurity_cssm.
+const uint8 kDomainComponentData[] = {
+  0x09, 0x92, 0x26, 0x89, 0x93, 0xF2, 0x2C, 0x64, 0x01, 0x19
+};
+
+const CSSM_OID kDomainComponent = {

[wtc, 2011/12/01 23:59:41]

Nit: kDomainComponent => kDomainComponentOID
                      or kOIDDomainComponent

+    arraysize(kDomainComponentData),
+    const_cast<uint8*>(kDomainComponentData)
+};
+
 const CSSM_OID* kOIDs[] = {
     &CSSMOID_CommonName,
     &CSSMOID_LocalityName,
     &CSSMOID_StateProvinceName,
     &CSSMOID_CountryName,
     &CSSMOID_StreetAddress,
     &CSSMOID_OrganizationName,
     &CSSMOID_OrganizationalUnitName,
-    &CSSMOID_DNQualifier      // This should be "DC" but is undoubtedly wrong.
-};                            // TODO(avi): Find the right OID.
+    &kDomainComponent,
+};
 
 // The following structs and templates work with Apple's very arcane and under-
 // documented SecAsn1Parser API, which is apparently the same as NSS's ASN.1
 // decoder:
 // http://www.mozilla.org/projects/security/pki/nss/tech-notes/tn1.html
 
 // These are used to parse the contents of a raw
 // BER DistinguishedName structure.
 
 struct KeyValuePair {
@@ skipping 263 matching lines @@
       match(locality_name, against.locality_name) &&
       match(state_or_province_name, against.state_or_province_name) &&
       match(country_name, against.country_name) &&
       match(street_addresses, against.street_addresses) &&
       match(organization_names, against.organization_names) &&
       match(organization_unit_names, against.organization_unit_names) &&
       match(domain_components, against.domain_components);
 }
 
 }  // namespace net